From: Andrew Dunstan <andrew@dunslane.net>
To: Heikki Linnakangas <hlinnaka@iki.fi>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix snapshot reference leak if lo_export fails.
Date: Thu, 4 Nov 2021 12:31:05 -0400
Message-ID: <5430d13d-baf6-a3d5-3ed8-e22056855068@dunslane.net> (raw)
In-Reply-To: <ff9c8400-382f-44c5-1729-8c759e7870ff@iki.fi>
References: <E1miCof-0006bt-DZ@gemulon.postgresql.org>
<DBA08346-9962-4706-92D1-230EE5201C10@yesql.se>
<ff9c8400-382f-44c5-1729-8c759e7870ff@iki.fi>
On 11/3/21 13:47, Heikki Linnakangas wrote:
> On 03/11/2021 13:06, Daniel Gustafsson wrote:
>>> On 3 Nov 2021, at 10:44, Heikki Linnakangas
>>> <heikki.linnakangas@iki.fi> wrote:
>>
>>> Fix snapshot reference leak if lo_export fails.
>>
>> This commit seems to lack the update in largeobject_1 as per hamerkop
>> in:
>
> Fixed, thanks!
>
> I'm a bit surprised none of the other Windows systems on the buildfarm
> complained. The difference in largeobject_1 output is apparently that
> the 'tenk.data' file uses Windows line endings. I guess that on all
> the other Windows hosts, git has been configured to use Unix line
> endings.
no, on drongo this comes up blank:
git config --get --show-origin core.eol
These days I often set:
git config --system core.eol lf
git config --system core.autocrlf input
because it makes repos checked out with Windows native git work nicely
with msys git, but I haven't done that on drongo.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, hlinnaka@iki.fi, daniel@yesql.se
Subject: Re: pgsql: Fix snapshot reference leak if lo_export fails.
In-Reply-To: <5430d13d-baf6-a3d5-3ed8-e22056855068@dunslane.net>
References: <E1miCof-0006bt-DZ@gemulon.postgresql.org> <DBA08346-9962-4706-92D1-230EE5201C10@yesql.se> <ff9c8400-382f-44c5-1729-8c759e7870ff@iki.fi> <5430d13d-baf6-a3d5-3ed8-e22056855068@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox