pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Date: Fri, 22 Mar 2019 12:32:57 -0400
Message-ID: <5446.1553272377@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WzmMakut=D8=TnmzhGtB+ELbb6k84LYNW28C8MZ2D-ZoJw@mail.gmail.com>
References: <E1h6eep-0001Mw-Vd@gemulon.postgresql.org>
	<CAH2-WzmFdW-e9+uG5BqzuW7YWBdL9=Vrwgmt5p6vndCeKJ5Z4w@mail.gmail.com>
	<13999.1553105283@sss.pgh.pa.us>
	<CAH2-Wznu+i765yrRcpKC0m9N2LEFWg=stjF73U7XmakSXWDDAg@mail.gmail.com>
	<CAH2-WzkCQ_MtKeOpzozj7QhhgP1unXsK8o9DMAFvDqQFEPpkYQ@mail.gmail.com>
	<24277.1553114810@sss.pgh.pa.us>
	<16667.1553116435@sss.pgh.pa.us>
	<17604.1553118255@sss.pgh.pa.us>
	<CAH2-WzmfxXs3bSX6T3DP1wTEWbyhkTiyPZ6o9t2DmcHbBtsCNA@mail.gmail.com>
	<17845.1553118645@sss.pgh.pa.us>
	<8748.1553119737@sss.pgh.pa.us>
	<CAH2-Wz=U8tcaP1wx4t2n8-grz-9ar2fPJeYu9MExSyOu_NVmiA@mail.gmail.com>
	<CAH2-Wzm0nQyV3x06_XEuH62tda8X6op-4r29uj8VA0XambsUpw@mail.gmail.com>
	<21983.1553138224@sss.pgh.pa.us>
	<CAH2-WzmMakut=D8=TnmzhGtB+ELbb6k84LYNW28C8MZ2D-ZoJw@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Mar 20, 2019 at 8:17 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Actually, I'm not sure why it would be fine to revert 7d3bf73ac now.
>>> Might the problem actually be the order in which OIDs are originally
>>> assigned, or something like that?

>> No, because then things would have been unstable before, no?

> Perhaps. The cost of being wrong here is trivial anyway. I have
> reverted 7d3bf73ac based on the assumption that it's now unnecessary.

Apparently, that case is indeed unstable, cf

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fulmar&dt=2019-03-22%2016%3A15%3A14

I picked up on that because I've also seen it happen on my own
devel machine today, but just once --- I then tried to reproduce it,
but couldn't in several dozen tries.

I'm fairly baffled as to why the output order would be unstable
given the sort, and even more as to why the instability didn't
emerge before.  Any thoughts?

			regards, tom lane




view thread (34+ messages)  latest in thread

Message-ID: <5446.1553272377@sss.pgh.pa.us>
Permalink:  ../5446.1553272377@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5446.1553272377@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
  In-Reply-To: <5446.1553272377@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox