From: Greg Burd <greg@burd.me>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
Date: Tue, 27 Jan 2026 11:53:38 -0500
Message-ID: <54F8BC8B-6F9D-4B91-8B68-AA02B7643B94@burd.me> (raw)
In-Reply-To: <544727.1769528979@sss.pgh.pa.us>
References: <E1vkc3p-002uNr-0e@gemulon.postgresql.org>
<CA+TgmobdVhO0ckZfsBZ0wqDO4qHVCwZZx8sf=EinafvUam-dsQ@mail.gmail.com>
<428236.1769526672@sss.pgh.pa.us>
<544727.1769528979@sss.pgh.pa.us>
> On Jan 27, 2026, at 10:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> This commit has broken CI for me.
>
>> Hmm, I wonder why the buildfarm seems fine with it ... I'm prepared
>> to believe a Windows-only problem, but at least hamerkop has run
>> since 851f664.
>
> D'oh: hamerkop doesn't run any TAP tests, let alone ones that require
> --enable-injection-points. So that success proves nothing.
>
> Our other Windows animals (drongo, fairywren, unicorn) seem to be
> configured with -Dtap_tests=enabled, but nothing about injection
> points, so they will also skip 046_checkpoint_logical_slot.
> Seems like a bit of a blind spot in the buildfarm.
>
> regards, tom lane
>
I'll see if I can update unicorn today to enable injection points to add some coverage on Win11/ARM64/MSVC. No promises that will be diagnostic at all, but it seems like a good idea.
-Dinjection_points=true
-greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: greg@burd.me, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Prevent invalidation of newly synced replication slots.
In-Reply-To: <54F8BC8B-6F9D-4B91-8B68-AA02B7643B94@burd.me>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox