From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Allow GiST distance function to return merely a lower-bound.
Date: Fri, 15 May 2015 15:17:47 +0300
Message-ID: <5555E3EB.6010200@iki.fi> (raw)
In-Reply-To: <CAHGQGwGNrFDGoP06c2Z_H9JSOL1JrsY9tKpD6Fws6Fz9bOnSpA@mail.gmail.com>
References: <E1YtDlp-0002at-3o@gemulon.postgresql.org>
<CAHGQGwGNrFDGoP06c2Z_H9JSOL1JrsY9tKpD6Fws6Fz9bOnSpA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 05/15/2015 03:05 PM, Fujii Masao wrote:
> Seems this patch causes the regression test of pg_trgm fail.
> The regression diff that I got is:
>
> *** /home/postgres/pgsql/head/contrib/pg_trgm/expected/pg_trgm.out
> 2013-07-23 16:46:22.212488785 +0900
> --- /home/postgres/pgsql/head/contrib/pg_trgm/results/pg_trgm.out
> 2015-05-15 20:59:16.574926732 +0900
> ***************
> *** 2332,2343 ****
> (3 rows)
>
> select t <-> 'q0987wertyu0988', t from test_trgm order by t <->
> 'q0987wertyu0988' limit 2;
> ! ?column? | t
> ! ----------+-------------
> ! 0.411765 | qwertyu0988
> ! 0.5 | qwertyu0987
> ! (2 rows)
> !
> drop index trgm_idx;
> create index trgm_idx on test_trgm using gin (t gin_trgm_ops);
> set enable_seqscan=off;
> --- 2332,2338 ----
> (3 rows)
>
> select t <-> 'q0987wertyu0988', t from test_trgm order by t <->
> 'q0987wertyu0988' limit 2;
> ! ERROR: index returned tuples in wrong order
> drop index trgm_idx;
> create index trgm_idx on test_trgm using gin (t gin_trgm_ops);
> set enable_seqscan=off;
Hmm, OK. pg_trgm works for me, but I'll take a look. (rover_firefly also
went red, due to rounding differences in the regression test)
- Heikki
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: hlinnaka@iki.fi, masao.fujii@gmail.com
Subject: Re: pgsql: Allow GiST distance function to return merely a lower-bound.
In-Reply-To: <5555E3EB.6010200@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox