From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove MSVC scripts
Date: Wed, 20 Dec 2023 10:35:37 -0500
Message-ID: <5762e81d-2a2a-b08d-a3ff-f2344a300171@dunslane.net> (raw)
In-Reply-To: <CA+TgmoY+10ONpBw+jReqZAszFWhepxe+uxFfOGLFdfNOyKxPOg@mail.gmail.com>
References: <E1rFkiX-00AzwU-AR@gemulon.postgresql.org>
<CA+TgmoY+10ONpBw+jReqZAszFWhepxe+uxFfOGLFdfNOyKxPOg@mail.gmail.com>
On 2023-12-20 We 09:19, Robert Haas wrote:
> On Tue, Dec 19, 2023 at 7:45 PM Michael Paquier <michael@paquier.xyz> wrote:
>> Remove MSVC scripts
> I think it's because of this commit that koel and crake now have this complaint:
>
> <blah blah lots of output>
> ./src/tools/version_stamp.pl syntax OK
> Can't locate Win32/Registry.pm in @INC (you may need to install the
> Win32::Registry module) (@INC entries checked: src/test/perl
> src/tools/msvc src/backend/catalog src/backend/utils/mb/Unicode
> src/bin/pg_rewind src/test/ssl/t src/tools/msvc/dummylib
> /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38
> /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl
> /usr/lib64/perl5 /usr/share/perl5) at ./src/tools/win32tzlist.pl line
> 21.
> BEGIN failed--compilation aborted at ./src/tools/win32tzlist.pl line 21.
>
> win32tzlist.pl still says "use Win32::Registry" but the commit removed
> src/tools/msvc/dummylib/Win32/Registry.pm.
>
Yeah, the commit removed our dummy version of Win32/Registry.pm. I have
disabled the test for that file on branches later than 16, and koel and
crake are back to green.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, robertmhaas@gmail.com, michael@paquier.xyz
Subject: Re: pgsql: Remove MSVC scripts
In-Reply-To: <5762e81d-2a2a-b08d-a3ff-f2344a300171@dunslane.net>
References: <E1rFkiX-00AzwU-AR@gemulon.postgresql.org> <CA+TgmoY+10ONpBw+jReqZAszFWhepxe+uxFfOGLFdfNOyKxPOg@mail.gmail.com> <5762e81d-2a2a-b08d-a3ff-f2344a300171@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox