From: Joe Conway <mail@joeconway.com>
To: Peter Eisentraut <peter@eisentraut.org>
To: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Subject: Re: pgsql: Move scanint8() to numutils.c
Date: Tue, 15 Feb 2022 10:39:34 -0500
Message-ID: <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com> (raw)
In-Reply-To: <E1nJijU-0000fr-0S@gemulon.postgresql.org>
References: <E1nJijU-0000fr-0S@gemulon.postgresql.org>
On 2/14/22 16:18, Peter Eisentraut wrote:
> Move scanint8() to numutils.c
>
> Move scanint8() to numutils.c and rename to pg_strtoint64(). We
> already have a "16" and "32" version of that, and the code inside the
> functions was aligned, so this move makes all three versions
> consistent. The API is also changed to no longer provide the errorOK
> case. Users that need the error checking can use strtoi64().
>
> Reviewed-by: John Naylor <john.naylor@enterprisedb.com>
> Discussion: https://www.postgresql.org/message-id/flat/b239564c-cad0-b23e-c57e-166d883cb97d@enterprisedb.com
(moving to hackers)
I guess shame on me for not noticing the thread, but I don't see any
discussion about the potential for breakage to external projects.
scanint8() is exported, and this change breaks at least two extensions I
maintain.
A quick scan (no pun intended ;-)) of github shows other potential
breakage, including at least older (still open source) versions of
pglogical.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: mail@joeconway.com, peter@eisentraut.org, pgsql-hackers@postgreSQL.org
Subject: Re: pgsql: Move scanint8() to numutils.c
In-Reply-To: <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com>
References: <E1nJijU-0000fr-0S@gemulon.postgresql.org> <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox