From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent infinity and NaN in jsonb/plperl transform
Date: Mon, 30 Apr 2018 14:36:45 -0400
Message-ID: <59e5787f-314e-6e5d-db5e-bcb6b9dbc25c@2ndquadrant.com> (raw)
In-Reply-To: <21194.1525110966@sss.pgh.pa.us>
References: <E1fDCX9-0005yu-7q@gemulon.postgresql.org>
<21194.1525110966@sss.pgh.pa.us>
On 4/30/18 13:56, Tom Lane wrote:
> So this isn't working on Windows:
>
> contrib/jsonb_plperl/jsonb_plperl.c(226): warning C4013: 'isnan' undefined; assuming extern returning int [c:\pgbuildfarm\pgbuildroot\HEAD\pgsql.build\jsonb_plperl.vcxproj]
> ...
> .\Release\jsonb_plperl\jsonb_plperl.dll : fatal error LNK1120: 1 unresolved externals [c:\pgbuildfarm\pgbuildroot\HEAD\pgsql.build\jsonb_plperl.vcxproj]
>
> The reason seems to be this kluge in plperl.h:
>
> /* stop perl headers from hijacking stdio and other stuff on Windows */
> #ifdef WIN32
> #define WIN32IO_IS_STDIO
> /*
> * isnan is defined in both the perl and mingw headers. We don't use it,
> * so this just clears up the compile warning.
> */
> #ifdef isnan
> #undef isnan
> #endif
> #endif /* WIN32 */
>
> Looks like the half-life of that hack just expired. What shall
> we do about it?
I have removed this for now. If it's really just about a compiler
warning, then we can find a different workaround later.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent infinity and NaN in jsonb/plperl transform
In-Reply-To: <59e5787f-314e-6e5d-db5e-bcb6b9dbc25c@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox