pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL
Date: Thu, 2 May 2024 12:30:01 +0300
Message-ID: <5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi> (raw)
In-Reply-To: <1C71E5C4-46BE-46B7-9884-310B25280B49@yesql.se>
References: <E1s1g0Z-000jeC-OR@gemulon.postgresql.org>
	<1C71E5C4-46BE-46B7-9884-310B25280B49@yesql.se>

On 02/05/2024 12:09, Daniel Gustafsson wrote:
>> On 30 Apr 2024, at 07:26, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote:
> 
>> Fix compilation on OpenSSL 1.0.2 and LibreSSL
>>
>> SSL_AD_NO_APPLICATION_PROTOCOL was introduced in OpenSSL 1.1.0.
> 
> +        * https://github.com/openssl/openssl/issues/24300.  This is available in
> +        * OpenSSL 1.1.0 and later, but as of this writing not in LibreSSL.
> 
> I'm a bit confused, as far as I can tell this has been in LibreSSL since the
> OpenBSD 6.9 release.
> 
> https://github.com/openbsd/src/blob/master/lib/libssl/ssl_tlsext.c#L130
> 
> Or am I missing something?

Hmm, I'm not sure how exactly LibreSSL is versioned. But morepork runs 
OpenBSD 6.9, and it was one of the failing buildfarm members: 
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=morepork&dt=2024-04-30%2004%3A30%3A28. 
And I don't see the symbol in a fresh checkout of the portable libressl 
repository at https://github.com/libressl/portable.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

view thread (7+ messages)  latest in thread

Message-ID: <5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi>
Permalink:  ../5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi/
Also on:    postgresql.org/message-id/5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: hlinnaka@iki.fi, daniel@yesql.se, heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL
  In-Reply-To: <5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox