From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL
Date: Sat, 4 May 2024 18:06:45 +0300
Message-ID: <ad1dd526-3537-441b-9966-f5fdb710f000@iki.fi> (raw)
In-Reply-To: <331BA556-4AAD-4B09-B86B-A5947F248E3F@yesql.se>
References: <E1s1g0Z-000jeC-OR@gemulon.postgresql.org>
<1C71E5C4-46BE-46B7-9884-310B25280B49@yesql.se>
<5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi>
<5EACEB09-BCBC-432A-A5B0-E8FD73808276@yesql.se>
<6f62a93d-3ebb-476f-8ff2-1187c790cd99@iki.fi>
<331BA556-4AAD-4B09-B86B-A5947F248E3F@yesql.se>
On 03/05/2024 11:44, Daniel Gustafsson wrote:
>> On 2 May 2024, at 12:30, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> On 02/05/2024 13:24, Daniel Gustafsson wrote:
>
>>> This makes targeting 7.0 as the lowest LibreSSL version appealing in my
>>> patchset for removing support for old OpenSSL and LibreSSL versions.
>>
>> Works for me. Although there's little harm in keeping the "#ifdef SSL_AD_NO_APPLICATION_PROTOCOL" either, if that's the only thing missing from 6.9.
>
> In the meantime I'll apply the below to keep the comment correct and to help
> future-me when revisiting SSL library support =)
>
> - * OpenSSL 1.1.0 and later, but as of this writing not in LibreSSL.
> + * OpenSSL 1.1.0 and later, as well as in LibreSSL 3.4.3 (OpenBSD 7.0) and
> + * later.
>
> Any objections to that?
Sounds good
--
Heikki Linnakangas
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: hlinnaka@iki.fi, daniel@yesql.se, heikki.linnakangas@iki.fi
Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL
In-Reply-To: <ad1dd526-3537-441b-9966-f5fdb710f000@iki.fi>
References: <E1s1g0Z-000jeC-OR@gemulon.postgresql.org> <1C71E5C4-46BE-46B7-9884-310B25280B49@yesql.se> <5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi> <5EACEB09-BCBC-432A-A5B0-E8FD73808276@yesql.se> <6f62a93d-3ebb-476f-8ff2-1187c790cd99@iki.fi> <331BA556-4AAD-4B09-B86B-A5947F248E3F@yesql.se> <ad1dd526-3537-441b-9966-f5fdb710f000@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox