pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
Date: Sat, 06 Nov 2021 18:24:21 -0400
Message-ID: <612842.1636237461@sss.pgh.pa.us> (raw)
In-Reply-To: <E1mXUOJ-0007BC-Sb@gemulon.postgresql.org>
References: <E1mXUOJ-0007BC-Sb@gemulon.postgresql.org>

Andres Freund <andres@anarazel.de> writes:
> windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.

I happened to notice from grepping that
src/backend/port/win32/crashdump.c has its own

#define WIN32_LEAN_AND_MEAN

Can't we remove that now?  (I kind of wonder what good it did at all,
considering postgres.h has already pulled in <windows.h>.)

			regards, tom lane





view thread (5+ messages)  latest in thread

Message-ID: <612842.1636237461@sss.pgh.pa.us>
Permalink:  ../612842.1636237461@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/612842.1636237461@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
  In-Reply-To: <612842.1636237461@sss.pgh.pa.us>
  References: <E1mXUOJ-0007BC-Sb@gemulon.postgresql.org> <612842.1636237461@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox