pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Steele <david@pgmasters.net>
To: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces.
Date: Tue, 15 Mar 2022 14:40:35 -0600
Message-ID: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net> (raw)
In-Reply-To: <E1nTw2R-0006B1-CV@gemulon.postgresql.org>
References: <E1nTw2R-0006B1-CV@gemulon.postgresql.org>

On 3/14/22 19:31, Thomas Munro wrote:
> Fix pg_basebackup with in-place tablespaces.
> 
> Previously, pg_basebackup from a cluster that contained an 'in-place'
> tablespace, as introduced by commit 7170f215, would produce a harmless
> warning on Unix and fail completely on Windows.

Perhaps I'm being picky, but seems like this logic should be wrapped in:

if (allow_in_place_tablespaces)
{
     <...>
}

I worry about strange effects when this GUC is not enabled.

Regards,
-David





view thread (9+ messages)  latest in thread

Message-ID: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net>
Permalink:  ../66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net/
Also on:    postgresql.org/message-id/66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: david@pgmasters.net, tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces.
  In-Reply-To: <66373991-e520-40c1-f1e8-c758c7b24cb7@pgmasters.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox