pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
Date: Thu, 12 Oct 2017 20:06:32 -0400
Message-ID: <6970.1507853192@sss.pgh.pa.us> (raw)
In-Reply-To: <20171012234829.efaorzn6daebxppc@alap3.anarazel.de>
References: <E1e2RML-0002do-Lc@gemulon.postgresql.org>
	<307.1507819498@sss.pgh.pa.us>
	<20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de>
	<20171012234829.efaorzn6daebxppc@alap3.anarazel.de>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Andres Freund <andres@anarazel.de> writes:
>> fe-connect.c:2382:6: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration]
>> Looks like we're missing
>> #include <sys/types.h>

> Hm, it got removed as part of
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9e3755ecb2d058f7d123dd35a2e17840061909...
> but that's not an explanation, because

Nope, because that's quite old.  The oldest make log on praxis for
sungazer is from 2015-08-31, and it contains these warning lines:

 auth.c:1585:2: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration]
 ip.c:228:31: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 pg_locale.c:1284:3: warning: implicit declaration of function 'wcstombs_l' [-Wimplicit-function-declaration]
 fe-connect.c:1991:6: warning: implicit declaration of function 'getpeereid' [-Wimplicit-function-declaration]
 ip.c:228:31: warning: large integer implicitly truncated to unsigned type [-Woverflow]

It looks like we have grown another occurrence of the "implicitly
truncated" nag, but otherwise it's the same warnings in the most
recent log.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (21+ messages)  latest in thread

Message-ID: <6970.1507853192@sss.pgh.pa.us>
Permalink:  ../6970.1507853192@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/6970.1507853192@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, noah@leadboat.com
  Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
  In-Reply-To: <6970.1507853192@sss.pgh.pa.us>
  References: <E1e2RML-0002do-Lc@gemulon.postgresql.org> <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171012234829.efaorzn6daebxppc@alap3.anarazel.de> <6970.1507853192@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox