pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Build ICU support by default.
4+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2023-04-19 dea4343535  Fix generation of distribution tarball
* pgsql: Build ICU support by default.
@ 2023-04-18 20:36 Jeff Davis <jdavis@postgresql.org>
  2023-04-19 00:46 ` Re: pgsql: Build ICU support by default. Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 4+ messages in thread

From: Jeff Davis @ 2023-04-18 20:36 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Build ICU support by default.

Discussion: https://postgr.es/m/82c4c816-06f6-d3e3-ba02-fca4a5cef065%40enterprisedb.com
Reviewed-by: Peter Eisentraut

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fcb21b3acdcb9a60313325618fd7080aa36f1626

Modified Files
--------------
.cirrus.yml                    |  1 +
configure                      | 36 +++++++-------------
configure.ac                   |  8 +++--
doc/src/sgml/installation.sgml | 76 +++++++++++++++++++++++-------------------
4 files changed, 61 insertions(+), 60 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Build ICU support by default.
  2023-04-18 20:36 pgsql: Build ICU support by default. Jeff Davis <jdavis@postgresql.org>
@ 2023-04-19 00:46 ` Michael Paquier <michael@paquier.xyz>
  2023-04-19 04:23   ` Re: pgsql: Build ICU support by default. Jeff Davis <pgsql@j-davis.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Michael Paquier @ 2023-04-19 00:46 UTC (permalink / raw)
  To: Jeff Davis <jdavis@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org

On Tue, Apr 18, 2023 at 08:36:45PM +0000, Jeff Davis wrote:
> Build ICU support by default.

As guaibasaurus is telling, this broke the generation of the
distribution tarball:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2023-04-19%2000%3A20%3A0...

The problem is easy to reproduce: just run "make dist" from the top of
the tree.  The fix is a bit more tricky, straight-forward once you
know that ./INSTALL is generated from the contents of
installation.sgml (learnt that the hard way), and is similar to
45aa88f where you should add a few extra rules to
standalone-profile.xsl to replace the links by some text.  I guess 
that you could just replace both references with "the documentation"
in this case, as the terms are specified in the paragraphs generated
in the ./INSTALL, like the attached.

Do you mind if I apply the attached to fix the issue?
--
Michael

Attachments:

collation-fix-make-dist.patch (text/x-diff, 1.1K) download diff --git a/doc/src/sgml/standalone-profile.xsl b/doc/src/sgml/standalone-profile.xsl index ea8a8f1728..1b3938a638 100644 --- a/doc/src/sgml/standalone-profile.xsl +++ b/doc/src/sgml/standalone-profile.xsl @@ -40,6 +40,10 @@ variant without links and references to the main documentation. <xsl:text>the documentation about client authentication and libpq</xsl:text> </xsl:template> +<xsl:template match="xref[@linkend='collation']"> + <xsl:text>the documentation</xsl:text> +</xsl:template> + <xsl:template match="xref[@linkend='docguide-toolsets']"> <xsl:text>the main documentation's appendix on documentation</xsl:text> </xsl:template> @@ -60,6 +64,10 @@ variant without links and references to the main documentation. <xsl:text>the documentation</xsl:text> </xsl:template> +<xsl:template match="xref[@linkend='locale-providers']"> + <xsl:text>the documentation</xsl:text> +</xsl:template> + <xsl:template match="xref[@linkend='plpython-python23']"> <xsl:text>the </xsl:text><application>PL/Python</application><xsl:text> documentation</xsl:text> </xsl:template>
signature.asc (application/pgp-signature, 832B) download ^ permalink raw reply [nested|flat] 4+ messages in thread

* Re: pgsql: Build ICU support by default.
  2023-04-18 20:36 pgsql: Build ICU support by default. Jeff Davis <jdavis@postgresql.org>
  2023-04-19 00:46 ` Re: pgsql: Build ICU support by default. Michael Paquier <michael@paquier.xyz>
@ 2023-04-19 04:23   ` Jeff Davis <pgsql@j-davis.com>
  2023-04-19 05:06     ` Re: pgsql: Build ICU support by default. Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 4+ messages in thread

From: Jeff Davis @ 2023-04-19 04:23 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; Jeff Davis <jdavis@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org

On Wed, 2023-04-19 at 09:46 +0900, Michael Paquier wrote:
> As guaibasaurus is telling, this broke the generation of the
> distribution tarball:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2023-04-19%2000%3A20%3A0...
> 
> The problem is easy to reproduce: just run "make dist" from the top
> of
> the tree.  The fix is a bit more tricky, straight-forward once you
> know that ./INSTALL is generated from the contents of
> installation.sgml (learnt that the hard way), and is similar to
> 45aa88f where you should add a few extra rules to
> standalone-profile.xsl to replace the links by some text.  I guess 
> that you could just replace both references with "the documentation"
> in this case, as the terms are specified in the paragraphs generated
> in the ./INSTALL, like the attached.

Ah, thank you.

> Do you mind if I apply the attached to fix the issue?

Please go ahead.

Regards,
	Jeff Davis






^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Build ICU support by default.
  2023-04-18 20:36 pgsql: Build ICU support by default. Jeff Davis <jdavis@postgresql.org>
  2023-04-19 00:46 ` Re: pgsql: Build ICU support by default. Michael Paquier <michael@paquier.xyz>
  2023-04-19 04:23   ` Re: pgsql: Build ICU support by default. Jeff Davis <pgsql@j-davis.com>
@ 2023-04-19 05:06     ` Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 4+ messages in thread

From: Michael Paquier @ 2023-04-19 05:06 UTC (permalink / raw)
  To: Jeff Davis <pgsql@j-davis.com>; +Cc: Jeff Davis <jdavis@postgresql.org>; pgsql-committers@lists.postgresql.org

On Tue, Apr 18, 2023 at 09:23:43PM -0700, Jeff Davis wrote:
> Please go ahead.

Okay, done.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2023-04-19 05:06 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-04-18 20:36 pgsql: Build ICU support by default. Jeff Davis <jdavis@postgresql.org>
2023-04-19 00:46 ` Michael Paquier <michael@paquier.xyz>
2023-04-19 04:23   ` Jeff Davis <pgsql@j-davis.com>
2023-04-19 05:06     ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox