From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Build ICU support by default.
Date: Wed, 19 Apr 2023 09:46:44 +0900
Message-ID: <ZD859FmcMRCNtz0W@paquier.xyz> (raw)
In-Reply-To: <E1pos4B-003jY6-OM@gemulon.postgresql.org>
References: <E1pos4B-003jY6-OM@gemulon.postgresql.org>
On Tue, Apr 18, 2023 at 08:36:45PM +0000, Jeff Davis wrote:
> Build ICU support by default.
As guaibasaurus is telling, this broke the generation of the
distribution tarball:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2023-04-19%2000%3A20%3A0...
The problem is easy to reproduce: just run "make dist" from the top of
the tree. The fix is a bit more tricky, straight-forward once you
know that ./INSTALL is generated from the contents of
installation.sgml (learnt that the hard way), and is similar to
45aa88f where you should add a few extra rules to
standalone-profile.xsl to replace the links by some text. I guess
that you could just replace both references with "the documentation"
in this case, as the terms are specified in the paragraphs generated
in the ./INSTALL, like the attached.
Do you mind if I apply the attached to fix the issue?
--
Michael
Attachments:collation-fix-make-dist.patch (text/x-diff, 1.1K) downloaddiff --git a/doc/src/sgml/standalone-profile.xsl b/doc/src/sgml/standalone-profile.xslindex ea8a8f1728..1b3938a638 100644--- a/doc/src/sgml/standalone-profile.xsl+++ b/doc/src/sgml/standalone-profile.xsl@@ -40,6 +40,10 @@ variant without links and references to the main documentation.
<xsl:text>the documentation about client authentication and libpq</xsl:text>
</xsl:template>
+<xsl:template match="xref[@linkend='collation']">+ <xsl:text>the documentation</xsl:text>+</xsl:template>+
<xsl:template match="xref[@linkend='docguide-toolsets']">
<xsl:text>the main documentation's appendix on documentation</xsl:text>
</xsl:template>
@@ -60,6 +64,10 @@ variant without links and references to the main documentation.
<xsl:text>the documentation</xsl:text>
</xsl:template>
+<xsl:template match="xref[@linkend='locale-providers']">+ <xsl:text>the documentation</xsl:text>+</xsl:template>+
<xsl:template match="xref[@linkend='plpython-python23']">
<xsl:text>the </xsl:text><application>PL/Python</application><xsl:text> documentation</xsl:text>
</xsl:template>
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Build ICU support by default.
In-Reply-To: <ZD859FmcMRCNtz0W@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox