public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: aio: Add core asynchronous I/O infrastructure
Date: Wed, 19 Mar 2025 12:42:28 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy@notafhjwiuec>
References: <[email protected]>
	<[email protected]>
	<ecqk4e772iqtwuwfu56yr3cv5wnzug6fpqvmwjcwlduqlom5xr@2fzz3cdycdyb>
	<[email protected]>
	<a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy@notafhjwiuec>

Andres Freund <[email protected]> writes:
> On 2025-03-18 11:26:15 -0400, Tom Lane wrote:
>> Well, if we don't want to fix it I can just adjust my warning-scraping
>> script to ignore these.  Let's wait a bit and see if any newer
>> compilers warn similarly before deciding.

> FWIW, adding a few casts does silence the warnings, at least on clang-3.9,
> which I had around.

As of now, the only BF members showing these warnings are ayu (clang
version 4.0.1-10~deb9u2), batfish (clang version 5.0.0-3~16.04.1),
and demoiselle (clang version 5.0.1).  None of those seem like
versions that anyone would use for code development anymore (clang 6.0
was released in March 2018), so I'm not feeling like these warnings
are important to silence.  Let's just ignore them.

> But there also are other warnings on that compiler, mainly stuff like:
> ../../home/andres/src/postgresql/src/interfaces/libpq/fe-auth-oauth-curl.c:1437:28: warning: suggest braces around initialization of subobject [-Wmissing-braces]
>         struct itimerspec spec = {0};

And even more so that, if it's so old it's not even in the buildfarm
anymore.  I do care about -Wmissing-braces on a version developers
might use, but ...

			regards, tom lane

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: aio: Add core asynchronous I/O infrastructure
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox