From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Change ThisTimeLineID from a global variable to a local variable
Date: Sun, 07 Nov 2021 12:23:25 -0500
Message-ID: <757856.1636305805@sss.pgh.pa.us> (raw)
In-Reply-To: <YYXJnUxgw9dZKxlX@paquier.xyz>
References: <E1mj2VM-0000XK-Hn@gemulon.postgresql.org>
<YYXJnUxgw9dZKxlX@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Nov 05, 2021 at 04:55:52PM +0000, Robert Haas wrote:
>> Change ThisTimeLineID from a global variable to a local variable.
> lapwing looks unhappy after this commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2021-11-05%2022%3A40%3A10
> xlog.c: In function 'StartupXLOG':
> xlog.c:7249:5: error: 'checkPointLoc' may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> xlog.c:6686:5: note: 'checkPointLoc' was declared here
Yeah. I've seen some older compilers complain about that code before,
but now there are over a dozen buildfarm members warning about it.
It's clearly a false positive, since checkPointLoc does get set in
the read_backup_label()-failure-return code path. I think we've
seen a few other places where likely-to-be-inlined functions have
to initialize their result variables to prevent compiler warnings,
so I stuck an initialization step into read_backup_label in hopes
of silencing it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, rhaas@postgresql.org
Subject: Re: pgsql: Change ThisTimeLineID from a global variable to a local variable
In-Reply-To: <757856.1636305805@sss.pgh.pa.us>
References: <E1mj2VM-0000XK-Hn@gemulon.postgresql.org> <YYXJnUxgw9dZKxlX@paquier.xyz> <757856.1636305805@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox