From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Change ThisTimeLineID from a global variable to a local variable
Date: Sat, 6 Nov 2021 09:17:33 +0900
Message-ID: <YYXJnUxgw9dZKxlX@paquier.xyz> (raw)
In-Reply-To: <E1mj2VM-0000XK-Hn@gemulon.postgresql.org>
References: <E1mj2VM-0000XK-Hn@gemulon.postgresql.org>
Hi Robert,
On Fri, Nov 05, 2021 at 04:55:52PM +0000, Robert Haas wrote:
> Change ThisTimeLineID from a global variable to a local variable.
>
> StartupXLOG() still has ThisTimeLineID as a local variable, but the
> remaining code in xlog.c now needs to the relevant TimeLineID by some
> other means. Mostly, this means that we now pass it as a function
> parameter to a bunch of functions where we didn't previously.
> However, a few cases require special handling:
lapwing looks unhappy after this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2021-11-05%2022%3A40%3A10
xlog.c: In function 'StartupXLOG':
xlog.c:7249:5: error: 'checkPointLoc' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
xlog.c:6686:5: note: 'checkPointLoc' was declared here
Thanks,
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, rhaas@postgresql.org
Subject: Re: pgsql: Change ThisTimeLineID from a global variable to a local variable
In-Reply-To: <YYXJnUxgw9dZKxlX@paquier.xyz>
References: <E1mj2VM-0000XK-Hn@gemulon.postgresql.org> <YYXJnUxgw9dZKxlX@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox