From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Julien Rouhaud <rjuju123@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add option to use ICU as global locale provider
Date: Fri, 18 Mar 2022 20:28:58 +0100
Message-ID: <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com> (raw)
In-Reply-To: <20220318092749.363m4uv6rq24lctz@jrouhaud>
References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org>
<YjPn5+Y9Gj58PlEW@paquier.xyz>
<20220318031244.tu3wwlyxxabzq3iu@jrouhaud>
<CA+hUKGK1rLK_4jGbRWiXMx_nrH4NzS6FqXF0sZxGivrQYMh1EA@mail.gmail.com>
<20220318063648.4ja6rxlyzvc3viio@jrouhaud>
<20220318074051.n46mkwp2zkbxeesf@jrouhaud>
<20220318092749.363m4uv6rq24lctz@jrouhaud>
On 18.03.22 10:27, Julien Rouhaud wrote:
> I'm attaching a patch that fixes both issues for me with ICU 50. Note that
> there's already a test that would have failed for CREATE DATABASE if initdb
> tests didn't fail first, so no new test needed.
>
> I ended up copy/pasting icu_set_collation_attributes() in initdb.c. There
> shouldn't be new attributes added in old ICU versions, and there are enough
> differences to make it work in the frontend that it didn't seems worth to have
> a single function.
Another option is that we just don't do the check in initdb. As the
tests show, you will then get an error from the backend call, so it's
really just a question of when the error is reported.
Why does your patch introduce a function check_icu_locale() that is only
called once? Did you have further plans for that?
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, rjuju123@gmail.com, thomas.munro@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add option to use ICU as global locale provider
In-Reply-To: <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com>
References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org> <YjPn5+Y9Gj58PlEW@paquier.xyz> <20220318031244.tu3wwlyxxabzq3iu@jrouhaud> <CA+hUKGK1rLK_4jGbRWiXMx_nrH4NzS6FqXF0sZxGivrQYMh1EA@mail.gmail.com> <20220318063648.4ja6rxlyzvc3viio@jrouhaud> <20220318074051.n46mkwp2zkbxeesf@jrouhaud> <20220318092749.363m4uv6rq24lctz@jrouhaud> <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox