From: Daniel Gustafsson <daniel@yesql.se>
To: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: Tue, 8 Apr 2025 13:40:04 +0200
Message-ID: <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se> (raw)
In-Reply-To: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas.vondra@postgresql.org> wrote:
>
> Add support for basic NUMA awareness
dogfish is a little bit upset it seems.
ninja: job failed: ccache gcc -Isrc/port/libpgport.a.p -Isrc/include -I../pgsql/src/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -g -fno-strict-aliasing -fwrapv -fexcess-precision=standard -D_GNU_SOURCE -Wmissing-prototypes -Wpointer-arith -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wdeclaration-after-statement -Wmissing-variable-declarations -Wno-format-truncation -Wno-stringop-truncation -fPIC -DFRONTEND -MD -MQ src/port/libpgport.a.p/pg_numa.c.o -MF src/port/libpgport.a.p/pg_numa.c.o.d -o src/port/libpgport.a.p/pg_numa.c.o -c ../pgsql/src/port/pg_numa.c
In file included from [01m[K../pgsql/src/include/postgres.h:49[m[K,
from [01m[K../pgsql/src/port/pg_numa.c:16[m[K:
[01m[K../pgsql/src/include/utils/elog.h:79:10:[m[K [01;31m[Kfatal error: [m[Kutils/errcodes.h: No such file or directory
79 | #include [01;31m[K"utils/errcodes.h"[m[K
| [01;31m[K^~~~~~~~~~~~~~~~~~[m[K
compilation terminated.
Looking at pg_numa.c, shouldn't the include of postgres.h have an #ifndef
FRONTEND guard for postgres_fe.h as well?
--
Daniel Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
In-Reply-To: <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox