pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Fri, 25 Mar 2022 16:09:04 -0400
Message-ID: <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> (raw)
In-Reply-To: <CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com>
References: <E1nUB2m-000CYD-DY@gemulon.postgresql.org>
	<20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de>
	<CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com>
	<CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com>
	<626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de>
	<CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com>


On 3/25/22 13:52, Robert Haas wrote:
> On Fri, Mar 25, 2022 at 12:36 PM Andres Freund <andres@anarazel.de> wrote:
>> Create a CF entry for it, or enable CI on a github repo?
> I created a CF entry for it. Then I had to try to Google around to
> find the URL from the cfbot, because it's not even linked from
> commitfest.postgresql.org for some reason. #blamemagnus
>
> I don't think that the Windows CI is running the TAP tests for
> contrib. At least, I can't find any indication of it in the output. So
> it doesn't really help to assess how portable this test is, unless I'm
> missing something.
>
> I looked through the Linux output. It looks to me like that does run
> the TAP tests for contrib. Unfortunately, the output is not in order
> and is also not labelled, so it's hard to tell what output goes with
> what contrib module. I named my test 001_basic.pl, but there are 12 of
> those already. I see that 13 copies of 001_basic.pl seem to have
> passed CI on Linux, so I guess the test ran and passed there. It seems
> like it would be an awfully good idea to mention the subdirectory name
> before each dump of output.



Duplication of TAP test names has long been something that's annoyed me.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (66+ messages)  latest in thread

Message-ID: <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net>
Permalink:  ../7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net/
Also on:    postgresql.org/message-id/7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, robertmhaas@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net>
  References: <E1nUB2m-000CYD-DY@gemulon.postgresql.org> <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <CA+TgmoZZJK7Tx1aG2yTsaOTuCdjQkB0wY9vNCTSqf7tAubtZAQ@mail.gmail.com> <CA+TgmoagO0Dofpy8PUyphNXaTovqRCpYOQuP+BKPeSe3kH1zJw@mail.gmail.com> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox