pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter@eisentraut.org>
To: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Migrate logical slots to the new node during an upgrade.
Date: Mon, 6 Nov 2023 09:43:21 -0500
Message-ID: <7b8a9460-5668-b372-04e6-7b52e9308493@dunslane.net> (raw)
In-Reply-To: <b4fb612d-ef0b-4db7-81b9-cf0701275491@eisentraut.org>
References: <E1qvptE-002LgU-FD@gemulon.postgresql.org>
	<b4fb612d-ef0b-4db7-81b9-cf0701275491@eisentraut.org>


On 2023-11-06 Mo 05:31, Peter Eisentraut wrote:
> On 26.10.23 04:14, Amit Kapila wrote:
>> Migrate logical slots to the new node during an upgrade.
>
> Something in this patch is causing the pg_upgrade test to be run in 
> the source directory and leaving files such as delete_old_cluster.sh 
> around there.  (This is under meson; there shouldn't be any new files 
> appearing in the source directory during the build.)  Check please.
>
>
>

The same probably applies to VPATH builds using Makefiles.

002_pg_upgrade.pl has this, which I think should cure the new script:


# In a VPATH build, we'll be started in the source directory, but we want
# to run pg_upgrade in the build directory so that any files generated 
finish
# in it, like delete_old_cluster.{sh,bat}.
chdir ${PostgreSQL::Test::Utils::tmp_check};


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (4+ messages)  latest in thread

Message-ID: <7b8a9460-5668-b372-04e6-7b52e9308493@dunslane.net>
Permalink:  ../7b8a9460-5668-b372-04e6-7b52e9308493@dunslane.net/
Also on:    postgresql.org/message-id/7b8a9460-5668-b372-04e6-7b52e9308493@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, peter@eisentraut.org, akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Migrate logical slots to the new node during an upgrade.
  In-Reply-To: <7b8a9460-5668-b372-04e6-7b52e9308493@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox