pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix createdb tests for C locale
Date: Tue, 20 Sep 2022 21:03:06 -0400
Message-ID: <7c298d81-5a35-cfae-2f1e-2852214dcb8e@dunslane.net> (raw)
In-Reply-To: <3faf6b88-039b-22f1-18aa-d974d05fb362@enterprisedb.com>
References: <E1oZ7Ss-000aC0-Uy@gemulon.postgresql.org>
	<YyWeU61YMFwjVdxE@msg.df7cb.de>
	<69170.1663425842@sss.pgh.pa.us>
	<3faf6b88-039b-22f1-18aa-d974d05fb362@enterprisedb.com>


On 2022-09-19 Mo 15:46, Peter Eisentraut wrote:
> On 17.09.22 16:44, Tom Lane wrote:
>> Christoph Berg <myon@debian.org> writes:
>>> This seems to have broken 15 on apt.pg.o/Debian:
>>
>> Fails on RHEL8 too, if LANG=C.
>> OK if LANG=C.utf8.
>>
>> (The lack of buildfarm complaints is distressing.  Apparently
>> our coverage of ICU is very thin.)
>
> This issue is with a combination of ICU and environment locale "C".
> There is ICU coverage in the build farm, but apparently none with C
> locale set.
>
>

Yep, it's been like that for 5 years, ever since we added support for
the ICU collation test. See
<https://github.com/PGBuildFarm/client-code/blob/main/PGBuild/Modules/TestICU.pm;
line 59:


    return unless $locale =~ /utf8/i;


We can change that of course, I'm open to suggestions.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (8+ messages)

Message-ID: <7c298d81-5a35-cfae-2f1e-2852214dcb8e@dunslane.net>
Permalink:  ../7c298d81-5a35-cfae-2f1e-2852214dcb8e@dunslane.net/
Also on:    postgresql.org/message-id/7c298d81-5a35-cfae-2f1e-2852214dcb8e@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, myon@debian.org
  Subject: Re: pgsql: Fix createdb tests for C locale
  In-Reply-To: <7c298d81-5a35-cfae-2f1e-2852214dcb8e@dunslane.net>
  References: <E1oZ7Ss-000aC0-Uy@gemulon.postgresql.org> <YyWeU61YMFwjVdxE@msg.df7cb.de> <69170.1663425842@sss.pgh.pa.us> <3faf6b88-039b-22f1-18aa-d974d05fb362@enterprisedb.com> <7c298d81-5a35-cfae-2f1e-2852214dcb8e@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox