From: Christoph Berg <myon@debian.org>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix createdb tests for C locale
Date: Sat, 17 Sep 2022 12:15:47 +0200
Message-ID: <YyWeU61YMFwjVdxE@msg.df7cb.de> (raw)
In-Reply-To: <E1oZ7Ss-000aC0-Uy@gemulon.postgresql.org>
References: <E1oZ7Ss-000aC0-Uy@gemulon.postgresql.org>
Re: Peter Eisentraut
> Fix createdb tests for C locale
>
> If the createdb tests run under the C locale, the database cluster
> will be initialized with encoding SQL_ASCII. With the checks added in
> c7db01e325a530ec38ec7ba57cd3ed32e123e33c, this will cause several
> ICU-related tests to fail because SQL_ASCII is not supported by ICU.
> To work around that, use initdb option -E UTF8 for those tests to get
> past that check.
This seems to have broken 15 on apt.pg.o/Debian:
00:49:04 make[2]: Leaving directory '/<<PKGBUILDDIR>>/build/src/test/subscription'
00:49:04 make -C icu check
00:49:04 make[2]: Entering directory '/<<PKGBUILDDIR>>/build/src/test/icu'
00:49:04 echo "+++ tap check in src/test/icu +++" && rm -rf '/<<PKGBUILDDIR>>/build/src/test/icu'/tmp_check && /bin/mkdir -p '/<<PKGBUILDDIR>>/build/src/test/icu'/tmp_check && cd /<<PKGBUILDDIR>>/build/../src/test/icu && TESTDIR='/<<PKGBUILDDIR>>/build/src/test/icu' PATH="/<<PKGBUILDDIR>>/build/tmp_install/usr/lib/postgresql/15/bin:/<<PKGBUILDDIR>>/build/src/test/icu:$PATH" LD_LIBRARY_PATH="/<<PKGBUILDDIR>>/build/tmp_install/usr/lib/x86_64-linux-gnu" PGPORT='65432' PG_REGRESS='/<<PKGBUILDDIR>>/build/src/test/icu/../../../src/test/regress/pg_regress' /usr/bin/prove -I /<<PKGBUILDDIR>>/build/../src/test/perl/ -I /<<PKGBUILDDIR>>/build/../src/test/icu --verbose t/*.pl
00:49:04 +++ tap check in src/test/icu +++
00:49:06
00:49:06 # Failed test 'ICU locale must be specified for ICU provider: error message'
00:49:06 # at t/010_database.pl line 60.
00:49:06 # 'psql:<stdin>:1: ERROR: encoding "SQL_ASCII" is not supported with ICU provider'
00:49:06 # doesn't match '(?^:ERROR: ICU locale must be specified)'
00:49:06 # Looks like you failed 1 test of 5.
00:49:06 t/010_database.pl ..
00:49:06 ok 1 - sort by database default locale
00:49:06 ok 2 - sort by explicit collation standard
00:49:06 ok 3 - sort by explicit collation upper first
00:49:06 ok 4 - ICU locale must be specified for ICU provider: exit code not 0
00:49:06 not ok 5 - ICU locale must be specified for ICU provider: error message
00:49:06 1..5
00:49:06 Dubious, test returned 1 (wstat 256, 0x100)
00:49:06 Failed 1/5 subtests
00:49:06
00:49:06 Test Summary Report
00:49:06 -------------------
00:49:06 t/010_database.pl (Wstat: 256 Tests: 5 Failed: 1)
00:49:06 Failed test: 5
00:49:06 Non-zero exit status: 1
00:49:06 Files=1, Tests=5, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.81 cusr 0.32 csys = 1.15 CPU)
00:49:06 Result: FAIL
00:49:06 make[2]: *** [Makefile:19: check] Error 1
00:49:06 make[2]: Leaving directory '/<<PKGBUILDDIR>>/build/src/test/icu'
https://pgdgbuild.dus.dg-i.net/job/postgresql-15-binaries-snapshot/194/architecture=amd64,distributi...
Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: myon@debian.org, peter@eisentraut.org
Subject: Re: pgsql: Fix createdb tests for C locale
In-Reply-To: <YyWeU61YMFwjVdxE@msg.df7cb.de>
References: <E1oZ7Ss-000aC0-Uy@gemulon.postgresql.org> <YyWeU61YMFwjVdxE@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox