pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow root-owned SSL private keys in libpq, not only the backend
Date: Thu, 31 Mar 2022 09:34:24 +0200
Message-ID: <7f85ef6d-250b-f5ec-9867-89f0b16d019f@enterprisedb.com> (raw)
In-Reply-To: <E1nPSHw-000bmH-Kk@gemulon.postgresql.org>
References: <E1nPSHw-000bmH-Kk@gemulon.postgresql.org>

On 02.03.22 17:57, Tom Lane wrote:
> Allow root-owned SSL private keys in libpq, not only the backend.
> 
> This change makes libpq apply the same private-key-file ownership
> and permissions checks that we have used in the backend since commit
> 9a83564c5.  Namely, that the private key can be owned by either the
> current user or root (with different file permissions allowed in the
> two cases).  This allows system-wide management of key files, which
> is just as sensible on the client side as the server, particularly
> when the client is itself some application daemon.
> 
> Sync the comments about this between libpq and the backend, too.
> 
> Back-patch of a59c79564 and 50f03473e into all supported branches.

I think this

     libpq_gettext("private key file \"%s\" is not a regular file"),

should have a trailing newline in the string.





view thread (8+ messages)  latest in thread

Message-ID: <7f85ef6d-250b-f5ec-9867-89f0b16d019f@enterprisedb.com>
Permalink:  ../7f85ef6d-250b-f5ec-9867-89f0b16d019f@enterprisedb.com/
Also on:    postgresql.org/message-id/7f85ef6d-250b-f5ec-9867-89f0b16d019f@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Allow root-owned SSL private keys in libpq, not only the backend
  In-Reply-To: <7f85ef6d-250b-f5ec-9867-89f0b16d019f@enterprisedb.com>
  References: <E1nPSHw-000bmH-Kk@gemulon.postgresql.org> <7f85ef6d-250b-f5ec-9867-89f0b16d019f@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox