pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlan@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove obsolete executor cleanup code
Date: Wed, 27 Sep 2023 21:08:36 -0400
Message-ID: <802307.1695863316@sss.pgh.pa.us> (raw)
In-Reply-To: <E1qlfPr-006N0N-S9@gemulon.postgresql.org>
References: <E1qlfPr-006N0N-S9@gemulon.postgresql.org>

Amit Langote <amitlan@postgresql.org> writes:
> After these modifications, the ExecEnd*() routines for ValuesScan,
> NamedTuplestoreScan, and WorkTableScan became redundant. So, this
> commit removes them.

This seems like quite a bad idea.  From a documentation standpoint
alone, it would be far better for these functions to exist but be
empty.

			regards, tom lane





view thread (3+ messages)  latest in thread

Message-ID: <802307.1695863316@sss.pgh.pa.us>
Permalink:  ../802307.1695863316@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/802307.1695863316@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove obsolete executor cleanup code
  In-Reply-To: <802307.1695863316@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox