From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@postgresql.org
Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
Date: Mon, 25 Sep 2017 14:51:44 -0400
Message-ID: <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com> (raw)
In-Reply-To: <E1dv9jI-0006oT-Fn@gemulon.postgresql.org>
References: <E1dv9jI-0006oT-Fn@gemulon.postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 9/21/17 18:13, Tom Lane wrote:
> Give a better error for duplicate entries in VACUUM/ANALYZE column list.
>
> Previously, the code didn't think about this case and would just try to
> analyze such a column twice.
In the error message, we should write "specified more than once" instead
of "specified twice", because that could otherwise look a bit silly:
VACUUM ANALYZE vaccluster(i,i,i);
ERROR: column "i" of relation "vaccluster" is specified twice
(Also, the "is" doesn't seem to fit there.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu
In-Reply-To: <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox