From: Arseny Sher <a.sher@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix "base" snapshot handling in logical decoding
Date: Fri, 06 Jul 2018 10:55:41 +0300
Message-ID: <87muv4iyrm.fsf@ars-thinkpad> (raw)
In-Reply-To: <20180705204824.3rfp6co4dr5ph4n6@alvherre.pgsql>
References: <87r2kliqja.fsf@ars-thinkpad>
<20180705204824.3rfp6co4dr5ph4n6@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I just don't see it that VACUUM FULL would change the xmin of anything
> to FrozenXid, and in my experiments it doesn't. Did you mean VACUUM
> FREEZE?
Well, docs for VACUUM say:
FREEZE
Selects aggressive “freezing” of tuples. Specifying FREEZE is
equivalent to performing VACUUM with the vacuum_freeze_min_age and
vacuum_freeze_table_age parameters set to zero. Aggressive freezing
is always performed when the table is rewritten, so this option is
redundant when FULL is specified.
So this is literally the same. rewrite_heap_tuple does the job.
> Thanks for the detective work! I pushed this test change.
Thank you, I appreciate this.
--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: a.sher@postgrespro.ru, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix "base" snapshot handling in logical decoding
In-Reply-To: <87muv4iyrm.fsf@ars-thinkpad>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox