From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: Thu, 20 Jun 2019 21:23:25 +0100
Message-ID: <87tvckypr5.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <22384.1561060731@sss.pgh.pa.us>
References: <20190620161400.6wtuybv64ihnfy6d@alap3.anarazel.de>
<20190620172838.GA21945@alvherre.pgsql>
<CA+TgmobK3TVoxNJ0vCwvLcAjjaLvMLFWcbEpWA042bT9VdVWfQ@mail.gmail.com>
<20190620182406.GD2480@tamriel.snowman.net>
<87y31wytdl.fsf@news-spur.riddles.org.uk>
<20190620192412.GG2480@tamriel.snowman.net>
<22384.1561060731@sss.pgh.pa.us>
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
>> I was referring to the fact that the regression was introduced by a,
>> presumably important, tzdb update (2019a, as mentioned above). At
>> least, I made the assumption that the commit of the import of 2019a
>> had more than just the change that introduced the regression, but
>> I'm happy to admit I'm no where near as close to the code here as
>> you/Tom here.
Tom> Keep in mind that dealing with whatever tzdb chooses to ship is
Tom> not optional from our standpoint. Even if we'd refused to import
Tom> 2019a, every installation using --with-system-tzdata (which, I
Tom> sincerely hope, includes most production installs) is going to
Tom> have to deal with it as soon as the respective platform vendor
Tom> gets around to shipping the tzdata update. So reverting that
Tom> commit was never on the table.
Exactly. But that means that if the combination of our arbitrary rules
and the data in the tzdb results in an undesirable result, then we have
no real option but to fix our rules (we can't reasonably expect the tzdb
upstream to choose zone names to make our alphabetical-order preference
come out right).
My commit was intended to be the minimum fix that would restore the
pre-2019a behavior on all systems.
--
Andrew (irc:RhodiumToad)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, sfrost@snowman.net, robertmhaas@gmail.com, alvherre@2ndquadrant.com, andres@anarazel.de, myon@debian.org, pgsql-hackers@postgresql.org
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
In-Reply-To: <87tvckypr5.fsf@news-spur.riddles.org.uk>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox