pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: John Naylor <john.naylor@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid creation of the free space map for small heap relations.
Date: Mon, 28 Jan 2019 00:48:51 -0500
Message-ID: <8872.1548654531@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1LjXLFZ0Q1mXO5h8b6Smw=hsDvT3ZLcw5wcXbC7TSuwEA@mail.gmail.com>
References: <E1gnwx4-0003C9-BR@gemulon.postgresql.org>
	<CAA4eK1KvRqjYYaYWpkb=g76uM=MkfN4xE4fN0S6dgwO0sj_jxA@mail.gmail.com>
	<CAA4eK1JntHd7X6dLJVPGYV917HejjhbMKXn9m_RnnCE162LbLA@mail.gmail.com>
	<877eepjt3p.fsf@news-spur.riddles.org.uk>
	<CAA4eK1LjXLFZ0Q1mXO5h8b6Smw=hsDvT3ZLcw5wcXbC7TSuwEA@mail.gmail.com>

Amit Kapila <amit.kapila16@gmail.com> writes:
> Yes, so this could be the cause of the problem.  I think we need to
> change the tests added by the patch such that they don't rely on
> vacuum to remove dead-row versions?  Do you or anybody else see any
> better way to fix this?

To be blunt, this patch needs to be reverted immediately.  The failures
that are showing up are not just "the fsm test is not portable" problems.
See for example

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mantid&dt=2019-01-28%2005%3A07%3A06

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dromedary&dt=2019-01-28%2003%3A07%3A39

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2019-01-28%2003%3A20%3A02

I don't know what the common thread is here, but you don't get to leave
the buildfarm broken this badly while you figure it out.

			regards, tom lane




view thread (29+ messages)  latest in thread

Message-ID: <8872.1548654531@sss.pgh.pa.us>
Permalink:  ../8872.1548654531@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8872.1548654531@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, andrew@tao11.riddles.org.uk, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org, john.naylor@2ndquadrant.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid creation of the free space map for small heap relations.
  In-Reply-To: <8872.1548654531@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox