From: David Steele <david@pgmasters.net>
To: Fujii Masao <masao.fujii@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: Further clarify how recovery target parameters are applied
Date: Thu, 7 Nov 2019 12:33:33 -0500
Message-ID: <8bd7266c-f720-1eda-c94e-77e815768b7b@pgmasters.net> (raw)
In-Reply-To: <CAHGQGwHN_42hsKGwZo8YjXvOR7XuqzoXxMzBacBFUDN-NQ6poA@mail.gmail.com>
References: <CAHGQGwF7tLDk=M5tGZx=ROy_o2-n9fQ5v6-fnzBNF1yWxoEZoA@mail.gmail.com>
<20191105132123.GA1578@alvherre.pgsql>
<CAHGQGwG2KenPa8hTtQ1opgpgVtMQcQ2oAx_mTkyV0YjgaN5M1w@mail.gmail.com>
<e87b6c74-ae0b-bc97-b4fd-3b26f5b25ea4@2ndquadrant.com>
<CAHGQGwHN_42hsKGwZo8YjXvOR7XuqzoXxMzBacBFUDN-NQ6poA@mail.gmail.com>
On 11/6/19 4:49 AM, Fujii Masao wrote:
> On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> On 2019-11-06 05:48, Fujii Masao wrote:
>>> Patch attached. As I argued upthread, IMO it's better to remove
>>> the latter description from the doc and the patch does that.
>>> Also the patch adds "mainly" into the former description.
>>
>> I think we should list explicitly what is applied and what is not. This
>> is the reference documentation after all.
>
> Or it might be better to add something like "This setting has no effect if
> in standby mode / archive recovery" into the description of each parameter,
> instead.
+1. This will probably be easier to maintain and less confusing overall.
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: david@pgmasters.net, masao.fujii@gmail.com, peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: Further clarify how recovery target parameters are applied
In-Reply-To: <8bd7266c-f720-1eda-c94e-77e815768b7b@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox