From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: Mon, 05 Apr 2021 18:57:47 -0400
Message-ID: <932059.1617663467@sss.pgh.pa.us> (raw)
In-Reply-To: <YGuSe6Q484Eshj2n@paquier.xyz>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
<513200.1617634642@sss.pgh.pa.us>
<YGuSe6Q484Eshj2n@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Apr 05, 2021 at 10:57:22AM -0400, Tom Lane wrote:
>> I didn't look at the code, but I bet this is similar to the race
>> conditions we've seen before where a server process may exit before
>> the perl test script finishes stuffing a command down the pipe.
> Hmm. Those failures refer to the 5th and 8th tests of
> 001_password.pl where connect_ok() is used. The only logical
> differences compared to the previous code are:
> - The addition of on_error_stop in connect_ok() to ignore any errors
> - The fact that this now defines a SQL query (was undef previously).
> - $Test::Builder::Level
> So, the problem is with on_error_stop.
No, I bet it is with "now defines a SQL query". That means there's
something to be stuffed down the pipe.
I find I can reproduce this pretty reliably on slower machines
here, if you want me to dig into it more carefully.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-Reply-To: <932059.1617663467@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox