From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: Tue, 6 Apr 2021 07:43:07 +0900
Message-ID: <YGuSe6Q484Eshj2n@paquier.xyz> (raw)
In-Reply-To: <513200.1617634642@sss.pgh.pa.us>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
<513200.1617634642@sss.pgh.pa.us>
On Mon, Apr 05, 2021 at 10:57:22AM -0400, Tom Lane wrote:
> Some of the buildfarm seems not to like this. gaur failed here:
Thanks. I did not notice these.
> I didn't look at the code, but I bet this is similar to the race
> conditions we've seen before where a server process may exit before
> the perl test script finishes stuffing a command down the pipe.
Hmm. Those failures refer to the 5th and 8th tests of
001_password.pl where connect_ok() is used. The only logical
differences compared to the previous code are:
- The addition of on_error_stop in connect_ok() to ignore any errors
- The fact that this now defines a SQL query (was undef previously).
- $Test::Builder::Level
So, the problem is with on_error_stop. That's not necessary anyway,
but I am a bit surprised that this would be an issue. I'll apply that
to see if it fixes the issue. If it does not, a revert would be
better at this stage.
--
Michael
Attachments:fix-auth-failure.patch (text/x-diff, 391B) downloaddiff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pmindex bbde34c929..95e107373b 100644--- a/src/test/perl/PostgresNode.pm+++ b/src/test/perl/PostgresNode.pm@@ -1901,8 +1901,7 @@ sub connect_ok
'postgres',
$sql,
extra_params => ['-w'],
- connstr => "$connstr",- on_error_stop => 0);+ connstr => "$connstr");
is($ret, 0, $test_name);
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-Reply-To: <YGuSe6Q484Eshj2n@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox