From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: SQL-standard function body
Date: Thu, 8 Apr 2021 08:25:16 +0200
Message-ID: <93cd20a5-1d4a-6cc9-a70a-41a7c8c4d80a@eisentraut.org> (raw)
In-Reply-To: <1730972.1617836766@sss.pgh.pa.us>
References: <E1lUEF5-00027L-N4@gemulon.postgresql.org>
<20210407225806.majgznh4lk34hjvu@alap3.anarazel.de>
<1730972.1617836766@sss.pgh.pa.us>
On 08.04.21 01:06, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2021-04-07 19:53:35 +0000, Peter Eisentraut wrote:
>>> SQL-standard function body
>
>> This is turning the BF red:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2021-04-07%2022%3A52%3A19
>> Might be force_parallel_mode=regress related.
>
> Yeah. On my machine, it's fine without force_parallel_mode and
> crashes with that. Looks like query text is not getting passed
> to the parallel worker in some cases.
There does not appear to be any indication in CreateQueryDesc() or for
es_sourceText that the query source text needs to be not NULL (unlike
PortalDefineQuery() for example). If we want that to be the case, an
assert in CreateQueryDesc() would be a straightforward way to catch
this. But for example code in CreateExecutorState() and
executor_errposition() is prepared to have es_sourceText be NULL, so
relative to that, the fix that Andres put into ExecInitParallelPlan() to
handle that as well seems appropriate.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: SQL-standard function body
In-Reply-To: <93cd20a5-1d4a-6cc9-a70a-41a7c8c4d80a@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox