pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve handling of inherited GENERATED expressions.
Date: Thu, 12 Jan 2023 09:46:00 -0500
Message-ID: <950928.1673534760@sss.pgh.pa.us> (raw)
In-Reply-To: <16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net>
References: <E1pFi7q-003BDS-DH@gemulon.postgresql.org>
	<ff51607f-f3d7-688f-90be-4f3d16cefd40@dunslane.net>
	<CA+HiwqFoaxUs2pYao7MWLh1_WpgWK_is8wcrQHT+6JDwf7jN1Q@mail.gmail.com>
	<16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net>

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-01-12 Th 08:30, Amit Langote wrote:
>> IIUC, by deciding to not back-patch this, we're expecting the user to
>> fix any child tables in the old cluster that have unsupported (in v16)
>> properties before upgrading to v16, right?  If that is indeed the
>> case, maybe this is again a case where TestUpgradeXversion.pm needs
>> tweaking?

> OK, please tell me exactly what I'm meant to tweak :-)

Yeah.  I think best bet may be to drop the problematic table(s),
as we've done for other de-supported DDL situations.  A quick
experiment suggests that

DROP TABLE gtest_normal_child;
DROP TABLE gtest_normal_child2;

should do it.

I can work on a better-tested patch for TestUpgradeXversion.pm, but
I have a couple other commitments today so it may take a bit of time.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <950928.1673534760@sss.pgh.pa.us>
Permalink:  ../950928.1673534760@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/950928.1673534760@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, amitlangote09@gmail.com
  Subject: Re: pgsql: Improve handling of inherited GENERATED expressions.
  In-Reply-To: <950928.1673534760@sss.pgh.pa.us>
  References: <E1pFi7q-003BDS-DH@gemulon.postgresql.org> <ff51607f-f3d7-688f-90be-4f3d16cefd40@dunslane.net> <CA+HiwqFoaxUs2pYao7MWLh1_WpgWK_is8wcrQHT+6JDwf7jN1Q@mail.gmail.com> <16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net> <950928.1673534760@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox