pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't Memoize lateral joins with volatile join conditions
Date: Mon, 07 Aug 2023 18:06:51 -0400
Message-ID: <954638.1691446011@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvoB6i1oC3hSvDGBu7UF=YZR1Cy6Ebwo7skcCPwZQFZV3Q@mail.gmail.com>
References: <E1qSxG8-000r3w-Au@gemulon.postgresql.org>
	<768799.1691413325@sss.pgh.pa.us>
	<CAApHDvoB6i1oC3hSvDGBu7UF=YZR1Cy6Ebwo7skcCPwZQFZV3Q@mail.gmail.com>

David Rowley <dgrowleyml@gmail.com> writes:
> On Tue, 8 Aug 2023 at 01:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Is this really something to be pushing into stable branches less than
>> 12 hours before a release wrap?

> My apologies. I had been under the impression that the go-no window
> was between stamp and tag and *that* was the window that was used for
> a buildfarm cycle. It sounds like it's not quite as black and white as
> that.  I'm not aware of any documentation which gives guidance on
> this.

Hmm.  Customarily we avoid pushing stuff into due-for-release branches
beginning 48-72 hours before the wrap, and then continuing until the
tags are applied ~24 hours after wrap.  The pause before wrap is to
allow a complete buildfarm test cycle even on slower machines.  The
pause after wrap is to wait for feedback from packagers.

> * https://wiki.postgresql.org/wiki/Committing_checklist

I thought we had something written down there after the last
discussion of this point, but maybe it was hanging fire because
we hadn't chosen a specific definition of when to start the pause.

> (I'm assuming backing the patch out now won't improve the situation,
> but please correct me if you think I'm wrong on that)

No, I've already made the tarballs.  I did look closely at the patch
and decided it was probably harmless and not in need of reversion.
I'm just whining because this wasn't following process.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <954638.1691446011@sss.pgh.pa.us>
Permalink:  ../954638.1691446011@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/954638.1691446011@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't Memoize lateral joins with volatile join conditions
  In-Reply-To: <954638.1691446011@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox