From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
Date: Mon, 28 Aug 2017 22:26:24 -0400
Message-ID: <9701.1503973584@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqSSq2_e4DjyR4sKgOoNGxewueF82np4EPHG8cF1tt4yLw@mail.gmail.com>
References: <CA+TgmoaDdiOL4DFS07ynmfYJw5kOZwixP83G1YKoV4xRAuH-=g@mail.gmail.com>
<20170828141631.zabmccmic7nmrel4@alvherre.pgsql>
<CA+Tgmobzki2RY+KhvNx3MOeN4ZRyFs98yetF7T+OfHir7hh__w@mail.gmail.com>
<CAB7nPqSSq2_e4DjyR4sKgOoNGxewueF82np4EPHG8cF1tt4yLw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Michael Paquier <michael.paquier@gmail.com> writes:
> I don't like breaking the abstraction of pg_log() with the existing
> flags with some kind of pg_debug() layer. The set of APIs present now
> in pg_rewind for logging is nice to have, and I think that those debug
> messages should be translated. So what about the attached?
Your point about INT64_FORMAT not necessarily working with fprintf
is an outstanding reason not to keep it like it is. I've not reviewed
this patch in detail but I think this is basically the way to fix it.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, robertmhaas@gmail.com, alvherre@2ndquadrant.com, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.
In-Reply-To: <9701.1503973584@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox