From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Add TAP tests for contrib/sslinfo
Date: Wed, 1 Dec 2021 21:58:10 +0100
Message-ID: <97EC3C0F-E7FB-4C5A-A15D-4E8F54CAF032@yesql.se> (raw)
In-Reply-To: <50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se>
References: <E1ms0iG-00050P-1G@gemulon.postgresql.org>
<058AAA2B-06CA-4D1C-8D24-B9EA6632C072@yesql.se>
<FB603D1D-2F48-48E1-B1BB-4DEF95DAF393@yesql.se>
<1632478.1638305700@sss.pgh.pa.us>
<887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se>
<1636597.1638308177@sss.pgh.pa.us>
<BF937964-0854-49DA-A4F4-51F4287EB304@yesql.se>
<1686601.1638333261@sss.pgh.pa.us>
<YacT3tm97xziSUFw@paquier.xyz>
<74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se>
<50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se>
> On 1 Dec 2021, at 20:49, Daniel Gustafsson <daniel@yesql.se> wrote:
> Looks like perl2host() was the missing piece, fairywren turned green with
> commit c3b34a0ff4. Thanks for pointing me in the right direction, I will draft
> a small paragraph on this to the TAP test README for other to learn from.
Would it make sense to add something like the attached to the Portability
section in the src/test/perl/README? It definitely would've helped me with
this particular issue, but that's admittedly a pretty limited samplesize.
--
Daniel Gustafsson https://vmware.com/Attachments:perl2host_readme.diff (application/octet-stream, 648B) downloaddiff --git a/src/test/perl/README b/src/test/perl/READMEindex 9e870830cf..fbb6e9384d 100644--- a/src/test/perl/README+++ b/src/test/perl/README@@ -126,3 +126,7 @@ Due to limitations of cpanm, this recipe doesn't exactly duplicate the
module list of older buildfarm animals. The discrepancies should seldom
matter, but if you want to be sure, bypass cpanm and instead manually
install the desired versions of Test::Simple and IPC::Run.
++When passing a path from the Perl test code to PostgreSQL, like for example+the path to an SSL certificate, it must be converted for use on the host+system by using PostgreSQL::Test::Utils::perl2host.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, michael@paquier.xyz, tgl@sss.pgh.pa.us, andrew@dunslane.net
Subject: Re: pgsql: Add TAP tests for contrib/sslinfo
In-Reply-To: <97EC3C0F-E7FB-4C5A-A15D-4E8F54CAF032@yesql.se>
References: <E1ms0iG-00050P-1G@gemulon.postgresql.org> <058AAA2B-06CA-4D1C-8D24-B9EA6632C072@yesql.se> <FB603D1D-2F48-48E1-B1BB-4DEF95DAF393@yesql.se> <1632478.1638305700@sss.pgh.pa.us> <887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se> <1636597.1638308177@sss.pgh.pa.us> <BF937964-0854-49DA-A4F4-51F4287EB304@yesql.se> <1686601.1638333261@sss.pgh.pa.us> <YacT3tm97xziSUFw@paquier.xyz> <74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se> <50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se> <97EC3C0F-E7FB-4C5A-A15D-4E8F54CAF032@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox