pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Amit Langote <amitlangote09@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix segfault during EvalPlanQual with mix of local and foreign p
Date: Tue, 7 Sep 2021 12:35:03 +0300
Message-ID: <9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi> (raw)
In-Reply-To: <CA+HiwqFQgNLS6VGntMcuJV6erBFV425xA6wBVnY=41GK4zC0Bw@mail.gmail.com>
References: <E1mE6Ep-0008Id-UZ@gemulon.postgresql.org>
	<CA+HiwqFQgNLS6VGntMcuJV6erBFV425xA6wBVnY=41GK4zC0Bw@mail.gmail.com>

On 06/09/2021 11:50, Amit Langote wrote:
> Quite late but to I was looking at this and noticed this comment:
> 
> +       /*
> +        * Direct modifications cannot be re-evaluated by EvalPlanQual, so
> +        * don't bother preparing the FDW.  There can ForeignScan nodes in the
> +        * EvalPlanQual subtree, but ExecForeignScan should never be called.
> +        */
> 
> The 2nd sentence seems to be missing a "be" between "can" and
> "ForeignScan".  Also, does it mean the following?
> 
> "There can be ForeignScan nodes in the EvalPlanQual plan subtree, but
> ExecForeignScan should never be called on them [during EvalPlanQual]."
> 
> I've attached a patch that changes the text like that.

Applied, thanks!

- Heikki





view thread (4+ messages)

Message-ID: <9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi>
Permalink:  ../9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi/
Also on:    postgresql.org/message-id/9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: hlinnaka@iki.fi, amitlangote09@gmail.com
  Subject: Re: pgsql: Fix segfault during EvalPlanQual with mix of local and foreign p
  In-Reply-To: <9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi>
  References: <E1mE6Ep-0008Id-UZ@gemulon.postgresql.org> <CA+HiwqFQgNLS6VGntMcuJV6erBFV425xA6wBVnY=41GK4zC0Bw@mail.gmail.com> <9f65a3fd-2be5-4e07-a04b-7f036780950f@iki.fi>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox