From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove the adminpack contrib extension
Date: Mon, 4 Mar 2024 20:08:16 +0100
Message-ID: <B5FC1FD8-01ED-4C22-BE98-8D483000E331@yesql.se> (raw)
In-Reply-To: <3690275.1709570049@sss.pgh.pa.us>
References: <202403041527.k2fsmwdgf6fy@alvherre.pgsql>
<0D569522-B87D-4178-A15E-9751905614EF@yesql.se>
<3690275.1709570049@sss.pgh.pa.us>
> On 4 Mar 2024, at 17:34, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> I see that my fix didn't solve it for 11 and 9.x on crake and drongo, will
>> rebuild more old trees and test to find the correct fix.
>
> The oldest branches didn't make that DB, so you need an "IF EXISTS".
> I pushed a fix after quickly checking it here.
Thanks for fixing, much appreciated!
The deviation between database names on crake found in the follow-up commit is
a bit concerning. Too much magic hidden away from the codetree makes it hard
to get tests right on the first try.
--
Daniel Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove the adminpack contrib extension
In-Reply-To: <B5FC1FD8-01ED-4C22-BE98-8D483000E331@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox