pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: hash: Add write-ahead logging support.
Date: Wed, 15 Mar 2017 07:53:49 +0530
Message-ID: <CAA4eK1+wfDRUpob2eyLdTNx73HerFmcw7VCkr4AL1+ZYt7qHHQ@mail.gmail.com> (raw)
In-Reply-To: <CA+TgmoZ7hPabY=+PH47iiDjRvUJ5eZyvXKFnNzfbGrRJp-w9xA@mail.gmail.com>
References: <E1cnqE2-0008JV-Uv@gemulon.postgresql.org>
	<5515.1489514099@sss.pgh.pa.us>
	<CA+TgmoZ7hPabY=+PH47iiDjRvUJ5eZyvXKFnNzfbGrRJp-w9xA@mail.gmail.com>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

On Tue, Mar 14, 2017 at 11:26 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <rhaas@postgresql.org> writes:
>>> hash: Add write-ahead logging support.
>>
>> This bit in access/hash/README, lines 368ff, appears obsolete:
>>
>>   Although we can survive a failure to split a bucket, a crash is likely to
>>   corrupt the index, since hash indexes are not yet WAL-logged.
>>
>> Perhaps we can just delete that para.  If not, what should it say now?
>
> That's obsolete, and can just be removed.
>

Agreed and posted a patch on hackers [1]

[1] - https://www.postgresql.org/message-id/CAA4eK1LeVu8rSvA%3DhfbezqjNv5x3nU-rPbHCHHbbsCrLX-0zAg%40mail.g...

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (13+ messages)  latest in thread

Message-ID: <CAA4eK1+wfDRUpob2eyLdTNx73HerFmcw7VCkr4AL1+ZYt7qHHQ@mail.gmail.com>
Permalink:  ../CAA4eK1+wfDRUpob2eyLdTNx73HerFmcw7VCkr4AL1+ZYt7qHHQ@mail.gmail.com/
Also on:    postgresql.org/message-id/CAA4eK1+wfDRUpob2eyLdTNx73HerFmcw7VCkr4AL1+ZYt7qHHQ@mail.gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: amit.kapila16@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: hash: Add write-ahead logging support.
  In-Reply-To: <CAA4eK1+wfDRUpob2eyLdTNx73HerFmcw7VCkr4AL1+ZYt7qHHQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox