pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Aleksander Alekseev <aleksander@timescale.com>
To: pgsql-committers@lists.postgresql.org
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Subject: Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
Date: Wed, 7 May 2025 13:35:01 +0300
Message-ID: <CAJ7c6TPkaYo12pycMfhEbFd7DdQP8URVvAdAFFnagWhuncmUsg@mail.gmail.com> (raw)
In-Reply-To: <CAPpHfdvBOTrcUqdOmVt+8WGOck0vZAWCiRBnTG=AuA-zGm3R_A@mail.gmail.com>
References: <E1uCZw6-000aRI-13@gemulon.postgresql.org>
	<CAJ7c6TPu3LTabgFkGUwuMKBbsMs_mk9H4Rz8cged8yX+V8+oqA@mail.gmail.com>
	<CAPpHfdvf+OF8qERNX5uQaygS3oHcAYoSSvyn4WpF9vW1BiCamg@mail.gmail.com>
	<CAJ7c6TMR2+_Dkr2riUpnA9N+p0y-jfeLvxfosaw+cR6hQ_BoOw@mail.gmail.com>
	<CAPpHfdsTOxhkvwVGhXEHBY4DK+yJWA3M0V6sYjrtcstOTDYrpw@mail.gmail.com>
	<CAJ7c6TMqoG5EB=g1jnkMdapgbWMRVeWS6G6eY8a9ax-jVJyQBQ@mail.gmail.com>
	<CAPpHfdvBOTrcUqdOmVt+8WGOck0vZAWCiRBnTG=AuA-zGm3R_A@mail.gmail.com>

Hi,

> OK, now I get your point: you think this should go to the next major
> release.  But no, it's not.  It's intended to eventually land into
> REL_18_STABLE, REL_18_BETA2 etc.  It addresses one of PG18 Open Items:
> Richard Guo found the way SJE changes ChangeVarNodes() unsatisfiable,
> and this commit is intended to fix that.  Also, note that it is not
> the only PG18 Open Item left after beta1, and fixing Open Items
> usually requires changes besides docs and whitespaces.

Now I get it. From the commit message it looked like a regular
refactoring. I didn't realize it fixes an open item.

Many thanks!

-- 
Best regards,
Aleksander Alekseev





view thread (13+ messages)

Message-ID: <CAJ7c6TPkaYo12pycMfhEbFd7DdQP8URVvAdAFFnagWhuncmUsg@mail.gmail.com>
Permalink:  ../CAJ7c6TPkaYo12pycMfhEbFd7DdQP8URVvAdAFFnagWhuncmUsg@mail.gmail.com/
Also on:    postgresql.org/message-id/CAJ7c6TPkaYo12pycMfhEbFd7DdQP8URVvAdAFFnagWhuncmUsg@mail.gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: aleksander@timescale.com, aekorotkov@gmail.com, akorotkov@postgresql.org
  Subject: Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
  In-Reply-To: <CAJ7c6TPkaYo12pycMfhEbFd7DdQP8URVvAdAFFnagWhuncmUsg@mail.gmail.com>
  References: <E1uCZw6-000aRI-13@gemulon.postgresql.org> <CAJ7c6TPu3LTabgFkGUwuMKBbsMs_mk9H4Rz8cged8yX+V8+oqA@mail.gmail.com> <CAPpHfdvf+OF8qERNX5uQaygS3oHcAYoSSvyn4WpF9vW1BiCamg@mail.gmail.com> <CAJ7c6TMR2+_Dkr2riUpnA9N+p0y-jfeLvxfosaw+cR6hQ_BoOw@mail.gmail.com> <CAPpHfdsTOxhkvwVGhXEHBY4DK+yJWA3M0V6sYjrtcstOTDYrpw@mail.gmail.com> <CAJ7c6TMqoG5EB=g1jnkMdapgbWMRVeWS6G6eY8a9ax-jVJyQBQ@mail.gmail.com> <CAPpHfdvBOTrcUqdOmVt+8WGOck0vZAWCiRBnTG=AuA-zGm3R_A@mail.gmail.com> <CAJ7c6TPkaYo12pycMfhEbFd7DdQP8URVvAdAFFnagWhuncmUsg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox