pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: John Naylor <johncnaylorls@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add template for adaptive radix tree
Date: Fri, 8 Mar 2024 10:37:29 +0700
Message-ID: <CANWCAZbd07sjGEezLwGodEheEUOxZbXp7V8FsGd+MHqqdtyAug@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvov7724UrD1Ug0D1eV+9Pd_x5VEQmw-6HVG9w1WdCxXPA@mail.gmail.com>
References: <CANWCAZYdT0EB4fn6iLiFAojJ8pQGfL_NQ_SVEjaFkBwLX2wKvQ@mail.gmail.com>
	<202403070936.rjwhdy5k62lp@alvherre.pgsql>
	<CANWCAZaPi7Gau3WBgOyB=jHpk72jqczJE1mHGZUZLvucagkjBQ@mail.gmail.com>
	<CANWCAZZc7vta4ArRVZjXCXoLiqmCMMUz5yDD_svWoMjET2RWxQ@mail.gmail.com>
	<CAApHDvov7724UrD1Ug0D1eV+9Pd_x5VEQmw-6HVG9w1WdCxXPA@mail.gmail.com>

On Fri, Mar 8, 2024 at 10:29 AM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Fri, 8 Mar 2024 at 13:48, John Naylor <johncnaylorls@gmail.com> wrote:
> > Now, after I get some coffee I'll look into the Windows failures.
>
> I had a look at this and the attached fixes the broken build on MSVC for me.
>
> I didn't take the time to fully understand it, but I did also try
> PGDLLEXPORT and that *didn't* fix it.  My guess is it's because these
> are function pointer variables rather than functions.

Thanks, I was getting close to committing a hackish workaround -- this
seems better!





view thread (14+ messages)  latest in thread

Message-ID: <CANWCAZbd07sjGEezLwGodEheEUOxZbXp7V8FsGd+MHqqdtyAug@mail.gmail.com>
Permalink:  ../CANWCAZbd07sjGEezLwGodEheEUOxZbXp7V8FsGd+MHqqdtyAug@mail.gmail.com/
Also on:    postgresql.org/message-id/CANWCAZbd07sjGEezLwGodEheEUOxZbXp7V8FsGd+MHqqdtyAug@mail.gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: johncnaylorls@gmail.com, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, john.naylor@postgresql.org
  Subject: Re: pgsql: Add template for adaptive radix tree
  In-Reply-To: <CANWCAZbd07sjGEezLwGodEheEUOxZbXp7V8FsGd+MHqqdtyAug@mail.gmail.com>
  References: <CANWCAZYdT0EB4fn6iLiFAojJ8pQGfL_NQ_SVEjaFkBwLX2wKvQ@mail.gmail.com> <202403070936.rjwhdy5k62lp@alvherre.pgsql> <CANWCAZaPi7Gau3WBgOyB=jHpk72jqczJE1mHGZUZLvucagkjBQ@mail.gmail.com> <CANWCAZZc7vta4ArRVZjXCXoLiqmCMMUz5yDD_svWoMjET2RWxQ@mail.gmail.com> <CAApHDvov7724UrD1Ug0D1eV+9Pd_x5VEQmw-6HVG9w1WdCxXPA@mail.gmail.com> <CANWCAZbd07sjGEezLwGodEheEUOxZbXp7V8FsGd+MHqqdtyAug@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox