From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Fix page modification outside of critical section in GIN
Date: Mon, 10 Feb 2020 19:03:48 +0300
Message-ID: <CAPpHfdvs9DXPG75PJ_k7TiHsqQEJzZJi7H0temAX3pUp80wh9w@mail.gmail.com> (raw)
In-Reply-To: <31240.1581267932@sss.pgh.pa.us>
References: <E1iXAuR-0001k9-Cn@gemulon.postgresql.org>
<21620.1581098806@sss.pgh.pa.us>
<31240.1581267932@sss.pgh.pa.us>
On Sun, Feb 9, 2020 at 8:05 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
> > Alexander Korotkov <akorotkov@postgresql.org> writes:
> >> Fix page modification outside of critical section in GIN
>
> > I happened to notice, while reviewing stuff for the release notes,
> > that this patch does not do what the commit message says. The
> > previous code modified the pd_prune_xid of the "dBuffer" page,
> > but now it's modifying the pd_prune_xid of the "lBuffer" page.
> > Is that actually correct?
>
> Since we're rapidly approaching the wrap deadline for this week's
> releases, I took it upon myself to review this code more carefully,
> and concluded that indeed it isn't correct. I pushed a fix that
> moves the GinPageSetDeleteXid call again.
Sorry for delayed response. Yes, my fix for oversight contain
oversight itself. I confirm the fix you've committed is correct.
Thank you!
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: a.korotkov@postgrespro.ru, tgl@sss.pgh.pa.us, akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix page modification outside of critical section in GIN
In-Reply-To: <CAPpHfdvs9DXPG75PJ_k7TiHsqQEJzZJi7H0temAX3pUp80wh9w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox