pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Daniel Gustafsson <daniel@yesql.se>
To: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: Tue, 15 Apr 2025 13:44:16 +0200
Message-ID: <CF6D7D7F-E1C4-45BE-9019-0F4B4BC7C135@yesql.se> (raw)
In-Reply-To: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>

> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas.vondra@postgresql.org> wrote:
> 
> Add support for basic NUMA awareness

It seems like this commit didn't run autoheader, which leaves a trivial diff in
pg_config.h.in carried over for future callers.  It doesn't change anuything
really as the HAVE_LIBNUMA macro isn't used, but for completeness sake we
should probably add it?

--
Daniel Gustafsson

Attachments:

libnuma_autoheader.diff (application/octet-stream, 747B) download
diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in
index 1af0b6316dd..c3cc9fa856d 100644
--- a/src/include/pg_config.h.in
+++ b/src/include/pg_config.h.in
@@ -249,6 +249,9 @@
 /* Define to 1 if you have the `m' library (-lm). */
 #undef HAVE_LIBM
 
+/* Define to 1 if you have the `numa' library (-lnuma). */
+#undef HAVE_LIBNUMA
+
 /* Define to 1 if you have the `pam' library (-lpam). */
 #undef HAVE_LIBPAM
 
@@ -689,7 +692,7 @@
 /* Define to 1 to build with libcurl support. (--with-libcurl) */
 #undef USE_LIBCURL
 
-/* Define to 1 to build with NUMA support. (--with-libnuma) */
+/* Define to build with NUMA support. (--with-libnuma) */
 #undef USE_LIBNUMA
 
 /* Define to build with io_uring support. (--with-liburing) */

view thread (13+ messages)  latest in thread

Message-ID: <CF6D7D7F-E1C4-45BE-9019-0F4B4BC7C135@yesql.se>
Permalink:  ../CF6D7D7F-E1C4-45BE-9019-0F4B4BC7C135@yesql.se/
Also on:    postgresql.org/message-id/CF6D7D7F-E1C4-45BE-9019-0F4B4BC7C135@yesql.se

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: daniel@yesql.se, tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add support for basic NUMA awareness
  In-Reply-To: <CF6D7D7F-E1C4-45BE-9019-0F4B4BC7C135@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox