From: Daniel Gustafsson <daniel@yesql.se>
To: Daniel Gustafsson <dgustafsson@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_rewind: Fetch small files according to new size.
Date: Tue, 5 Apr 2022 21:46:27 +0200
Message-ID: <D95829A7-630F-4CB8-AD32-C450210F606A@yesql.se> (raw)
In-Reply-To: <13C2BF64-4A6D-47E4-9181-3A658F00C9B7@yesql.se>
References: <E1nbioy-000R0E-Pr@gemulon.postgresql.org>
<13C2BF64-4A6D-47E4-9181-3A658F00C9B7@yesql.se>
> On 5 Apr 2022, at 15:36, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> On 5 Apr 2022, at 15:02, Daniel Gustafsson <dgustafsson@postgresql.org> wrote:
>>
>> pg_rewind: Fetch small files according to new size.
>
> The buildfarm is less impressed than CI was, I’m collecting more feedback and will then fix.
Sorry for being slow, life took over and children with fever took priority.
The error in question was:
local_source.c:118:15: error: format specifies type 'unsigned long long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
srcpath, len, written_len);
~~~~~~~~~^~~~~~~~~~~~~~~~~
I'm running a fixup with casting to int and printing with %d (like how
pg_rewind.c:digestControlFile already does it for printing a size_t) through CI
just to be sure and will push once it's had a green run:
- pg_fatal("size of source file \"%s\" changed concurrently: " UINT64_FORMAT " bytes expected, " UINT64_FORMAT " copied",
- srcpath, len, written_len);
+ pg_fatal("size of source file \"%s\" changed concurrently: %d bytes expected, %d copied",
+ srcpath, (int) len, (int) written_len);
--
Daniel Gustafsson https://vmware.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, dgustafsson@postgresql.org
Subject: Re: pgsql: pg_rewind: Fetch small files according to new size.
In-Reply-To: <D95829A7-630F-4CB8-AD32-C450210F606A@yesql.se>
References: <E1nbioy-000R0E-Pr@gemulon.postgresql.org> <13C2BF64-4A6D-47E4-9181-3A658F00C9B7@yesql.se> <D95829A7-630F-4CB8-AD32-C450210F606A@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox