agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Fix lack of message pluralization
18+ messages / 4 participants
[nested] [flat]
* pgsql: Fix lack of message pluralization
@ 2013-07-10 01:05 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2013-07-10 01:05 UTC (permalink / raw)
To: pgsql-committers
Fix lack of message pluralization
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/8dead08c54826e5927bf7a07caa94a86e6981aa0
Modified Files
--------------
src/backend/postmaster/postmaster.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2013-07-10 01:05 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2013-07-10 01:05 UTC (permalink / raw)
To: pgsql-committers
Fix lack of message pluralization
Branch
------
REL9_3_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/bf470b37cc7c9e018e9f789996ef45e35b442487
Modified Files
--------------
src/backend/postmaster/postmaster.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2021-02-10 10:44 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2021-02-10 10:44 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4ad5611055c8381d6a9b54fc11838418a1f14bc9
Modified Files
--------------
src/backend/access/transam/xlogfuncs.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2021-07-14 07:18 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2021-07-14 07:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b4842a8d085e970ff24667954c0d861e911e16c1
Modified Files
--------------
src/backend/storage/ipc/signalfuncs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2021-07-14 07:18 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2021-07-14 07:18 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/55b2a2340758da8ff11357d719d169f264ac7112
Modified Files
--------------
src/backend/storage/ipc/signalfuncs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2023-08-24 12:31 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2023-08-24 12:31 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d71e6055e45318b5cff2094025d641b954517fa9
Modified Files
--------------
src/backend/replication/slot.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2023-08-24 12:31 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2023-08-24 12:31 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ce18252d0b48d206d42cfbe1028e48d776e01831
Modified Files
--------------
src/backend/replication/slot.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2026-09-03 10:47 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 10:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Fixups for commits b99b74144f9, 79b101486c1, bf7d19be9b1.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/534db08f972852b77ea5e96e77d5fe45f3d8df93
Modified Files
--------------
src/backend/commands/trigger.c | 6 ++++--
src/backend/replication/logical/worker.c | 18 ++++++++++++------
src/backend/utils/time/snapmgr.c | 17 +++++++++++++----
3 files changed, 29 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2026-09-03 10:47 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 10:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Fixups for commits b99b74144f9, 79b101486c1, bf7d19be9b1.
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bb238161f910cefe67c7c24522e817c831ea4909
Modified Files
--------------
src/backend/commands/trigger.c | 6 ++++--
src/backend/replication/logical/worker.c | 18 ++++++++++++------
src/backend/utils/time/snapmgr.c | 17 +++++++++++++----
3 files changed, 29 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2026-09-03 10:47 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 10:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Fixups for commits b99b74144f9, 79b101486c1, bf7d19be9b1.
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/672f4ac4a3fcc791cfd3eb3e5dc2bb1c962c8a8c
Modified Files
--------------
src/backend/commands/trigger.c | 6 ++++--
src/backend/replication/logical/worker.c | 18 ++++++++++++------
src/backend/utils/time/snapmgr.c | 17 +++++++++++++----
3 files changed, 29 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2026-09-03 10:47 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 10:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Fixups for commits b99b74144f9, 79b101486c1, bf7d19be9b1.
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ec3f6a6a7dd82a8ce455a0710ef75172f9f318d1
Modified Files
--------------
src/backend/commands/trigger.c | 6 ++++--
src/backend/replication/logical/worker.c | 18 ++++++++++++------
src/backend/utils/time/snapmgr.c | 17 +++++++++++++----
3 files changed, 29 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2026-09-03 10:47 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 10:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Fixups for commits b99b74144f9, 79b101486c1, bf7d19be9b1.
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/df530e2342d1190b7b6d6893c524c5898f814acc
Modified Files
--------------
src/backend/commands/trigger.c | 6 ++++--
src/backend/replication/logical/worker.c | 18 ++++++++++++------
src/backend/utils/time/snapmgr.c | 17 +++++++++++++----
3 files changed, 29 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2026-09-03 10:47 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 10:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Fixups for commits b99b74144f9, 79b101486c1, bf7d19be9b1.
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ba7f9d95e6a0a4c01b18a07bebbeb487256a7ad3
Modified Files
--------------
src/backend/commands/trigger.c | 6 ++++--
src/backend/replication/logical/worker.c | 18 ++++++++++++------
src/backend/utils/time/snapmgr.c | 17 +++++++++++++----
3 files changed, 29 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* pgsql: Fix lack of message pluralization
@ 2026-09-03 10:47 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 10:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix lack of message pluralization
Fixups for commits b99b74144f9, 79b101486c1, bf7d19be9b1.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f419fad428639ce515a53ab7450c78ef60105960
Modified Files
--------------
src/backend/commands/trigger.c | 6 ++++--
src/backend/replication/logical/worker.c | 18 ++++++++++++------
src/backend/utils/time/snapmgr.c | 17 +++++++++++++----
3 files changed, 29 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 18+ messages in thread
* Re: pgsql: Fix lack of message pluralization
@ 2026-09-03 11:29 Daniel Gustafsson <daniel@yesql.se>
parent: Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 18+ messages in thread
From: Daniel Gustafsson @ 2026-09-03 11:29 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org
> On 3 Sep 2026, at 12:47, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> Fix lack of message pluralization
Maybe I'm daft, but why is the message below pluralized since the %d parameter
is the same?
--- a/src/backend/commands/trigger.c
+++ b/src/backend/commands/trigger.c
@@ -904,8 +904,10 @@ CreateTriggerFiringOn(const CreateTrigStmt *stmt, const char *queryString,
if (nargs > PG_INT16_MAX)
ereport(ERROR,
errcode(ERRCODE_TOO_MANY_ARGUMENTS),
- errmsg("triggers cannot have more than %d arguments",
- PG_INT16_MAX));
+ errmsg_plural("triggers cannot have more than %d argument",
+ "triggers cannot have more than %d arguments",
+ PG_INT16_MAX,
+ PG_INT16_MAX));
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 18+ messages in thread
* Re: pgsql: Fix lack of message pluralization
@ 2026-09-03 12:49 Peter Eisentraut <peter@eisentraut.org>
parent: Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 18+ messages in thread
From: Peter Eisentraut @ 2026-09-03 12:49 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: pgsql-committers@lists.postgresql.org
On 03.09.26 13:29, Daniel Gustafsson wrote:
>> On 3 Sep 2026, at 12:47, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Fix lack of message pluralization
>
> Maybe I'm daft, but why is the message below pluralized since the %d parameter
> is the same?
Do you mean the parameter is constant?
This is correct, but we have some precedent to pluralize these kinds of
things anyway. Several reasons:
- Translators shouldn't have to look into the source code what the
actual value is. (Or, in this case, even beyond the actual source code.)
- Maybe tomorrow someone changes this to PG_UINT16_MAX, and then it
might have to be translated differently.
- Not in this specific case but in general: You might have the same
message in different contexts but with different numbers.
> --- a/src/backend/commands/trigger.c
> +++ b/src/backend/commands/trigger.c
> @@ -904,8 +904,10 @@ CreateTriggerFiringOn(const CreateTrigStmt *stmt, const char *queryString,
> if (nargs > PG_INT16_MAX)
> ereport(ERROR,
> errcode(ERRCODE_TOO_MANY_ARGUMENTS),
> - errmsg("triggers cannot have more than %d arguments",
> - PG_INT16_MAX));
> + errmsg_plural("triggers cannot have more than %d argument",
> + "triggers cannot have more than %d arguments",
> + PG_INT16_MAX,
> + PG_INT16_MAX));
^ permalink raw reply [nested|flat] 18+ messages in thread
* Re: pgsql: Fix lack of message pluralization
@ 2026-09-03 12:51 Daniel Gustafsson <daniel@yesql.se>
parent: Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 18+ messages in thread
From: Daniel Gustafsson @ 2026-09-03 12:51 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org
> On 3 Sep 2026, at 14:49, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 03.09.26 13:29, Daniel Gustafsson wrote:
>>> On 3 Sep 2026, at 12:47, Peter Eisentraut <peter@eisentraut.org> wrote:
>>>
>>> Fix lack of message pluralization
>> Maybe I'm daft, but why is the message below pluralized since the %d parameter
>> is the same?
>
> Do you mean the parameter is constant?
Right.
> This is correct, but we have some precedent to pluralize these kinds of things anyway. Several reasons:
>
> - Translators shouldn't have to look into the source code what the actual value is. (Or, in this case, even beyond the actual source code.)
>
> - Maybe tomorrow someone changes this to PG_UINT16_MAX, and then it might have to be translated differently.
>
> - Not in this specific case but in general: You might have the same message in different contexts but with different numbers.
Makes sense, thanks for explaining!
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 18+ messages in thread
* Re: pgsql: Fix lack of message pluralization
@ 2026-09-04 05:46 Michael Paquier <michael@paquier.xyz>
parent: Daniel Gustafsson <daniel@yesql.se>
0 siblings, 0 replies; 18+ messages in thread
From: Michael Paquier @ 2026-09-04 05:46 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: Peter Eisentraut <peter@eisentraut.org>; pgsql-committers@lists.postgresql.org
On Thu, Sep 03, 2026 at 02:51:31PM +0200, Daniel Gustafsson wrote:
> On 3 Sep 2026, at 14:49, Peter Eisentraut <peter@eisentraut.org> wrote:
>> This is correct, but we have some precedent to pluralize these
>> kinds of things anyway. Several reasons:
>>
>> - Translators shouldn't have to look into the source code what the
>> - actual value is. (Or, in this case, even beyond the actual
>> - source code.)
>>
>> - Maybe tomorrow someone changes this to PG_UINT16_MAX, and then
>> - it might have to be translated differently.
>>
>> - Not in this specific case but in general: You might have the
>> - same message in different contexts but with different numbers.
>
> Makes sense, thanks for explaining!
Commenting as the guy who has touched the trigger code and added this
message. Thanks for the explanation, will keep that in mind.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../appbJFfMR7S_74C7@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 18+ messages in thread
end of thread, other threads:[~2026-09-04 05:46 UTC | newest]
Thread overview: 18+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2013-07-10 01:05 pgsql: Fix lack of message pluralization Peter Eisentraut <peter_e@gmx.net>
2013-07-10 01:05 pgsql: Fix lack of message pluralization Peter Eisentraut <peter_e@gmx.net>
2021-02-10 10:44 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2021-07-14 07:18 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2021-07-14 07:18 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2023-08-24 12:31 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2023-08-24 12:31 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2026-09-03 10:47 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2026-09-03 11:29 ` Daniel Gustafsson <daniel@yesql.se>
2026-09-03 12:49 ` Peter Eisentraut <peter@eisentraut.org>
2026-09-03 12:51 ` Daniel Gustafsson <daniel@yesql.se>
2026-09-04 05:46 ` Michael Paquier <michael@paquier.xyz>
2026-09-03 10:47 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2026-09-03 10:47 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2026-09-03 10:47 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2026-09-03 10:47 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2026-09-03 10:47 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
2026-09-03 10:47 pgsql: Fix lack of message pluralization Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox