agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix lack of message pluralization
Date: Fri, 4 Sep 2026 14:46:12 +0900
Message-ID: <appbJFfMR7S_74C7@paquier.xyz> (raw)
In-Reply-To: <D72A9192-A40D-41E4-9BA4-70C9D3315B3F@yesql.se>
References: <E1x24yT-00000003Iyo-0S6h@gemulon.postgresql.org>
<BDA7E255-6E17-4F6E-AD88-0363BF2623F3@yesql.se>
<b0ab6539-8ad6-4b09-a9fc-70414713ddbe@eisentraut.org>
<D72A9192-A40D-41E4-9BA4-70C9D3315B3F@yesql.se>
On Thu, Sep 03, 2026 at 02:51:31PM +0200, Daniel Gustafsson wrote:
> On 3 Sep 2026, at 14:49, Peter Eisentraut <peter@eisentraut.org> wrote:
>> This is correct, but we have some precedent to pluralize these
>> kinds of things anyway. Several reasons:
>>
>> - Translators shouldn't have to look into the source code what the
>> - actual value is. (Or, in this case, even beyond the actual
>> - source code.)
>>
>> - Maybe tomorrow someone changes this to PG_UINT16_MAX, and then
>> - it might have to be translated differently.
>>
>> - Not in this specific case but in general: You might have the
>> - same message in different contexts but with different numbers.
>
> Makes sense, thanks for explaining!
Commenting as the guy who has touched the trigger code and added this
message. Thanks for the explanation, will keep that in mind.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../appbJFfMR7S_74C7@paquier.xyz/2-signature.asc)
download
view thread (18+ messages)
Message-ID: <appbJFfMR7S_74C7@paquier.xyz>
Permalink: ../appbJFfMR7S_74C7@paquier.xyz/
Also on: postgresql.org/message-id/appbJFfMR7S_74C7@paquier.xyz
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, daniel@yesql.se, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix lack of message pluralization
In-Reply-To: <appbJFfMR7S_74C7@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox