pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix broken multibyte regression tests.
5+ messages / 3 participants
[nested] [flat]
* pgsql: Fix broken multibyte regression tests.
@ 2015-08-09 02:09 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 2 replies; 5+ messages in thread
From: Tatsuo Ishii @ 2015-08-09 02:09 UTC (permalink / raw)
To: pgsql-committers
Fix broken multibyte regression tests.
commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte
regression tests because the commit removes the warning message when
temporary hash indexes is created, which has been added by commit
07af523870bcfe930134054febd3a6a114942e5b.
Back patched to 9.5 stable tree.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/efc1610b64b04e7cf08cc1d6c608ede8b7d5ff07
Modified Files
--------------
src/test/mb/expected/big5.out | 1 -
src/test/mb/expected/euc_jp.out | 1 -
src/test/mb/expected/euc_kr.out | 1 -
src/test/mb/expected/euc_tw.out | 1 -
src/test/mb/expected/gb18030.out | 1 -
src/test/mb/expected/mule_internal.out | 2 --
src/test/mb/expected/sjis.out | 1 -
src/test/mb/expected/utf8.out | 1 -
8 files changed, 9 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix broken multibyte regression tests.
@ 2015-08-09 02:09 Tatsuo Ishii <ishii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Tatsuo Ishii @ 2015-08-09 02:09 UTC (permalink / raw)
To: pgsql-committers
Fix broken multibyte regression tests.
commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte
regression tests because the commit removes the warning message when
temporary hash indexes is created, which has been added by commit
07af523870bcfe930134054febd3a6a114942e5b.
Back patched to 9.5 stable tree.
Branch
------
REL9_5_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/479cb1e420c40d78b49535c0ceeaa5f65c7d6797
Modified Files
--------------
src/test/mb/expected/big5.out | 1 -
src/test/mb/expected/euc_jp.out | 1 -
src/test/mb/expected/euc_kr.out | 1 -
src/test/mb/expected/euc_tw.out | 1 -
src/test/mb/expected/gb18030.out | 1 -
src/test/mb/expected/mule_internal.out | 2 --
src/test/mb/expected/sjis.out | 1 -
src/test/mb/expected/utf8.out | 1 -
8 files changed, 9 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Fix broken multibyte regression tests.
@ 2015-08-09 02:48 Robert Haas <robertmhaas@gmail.com>
parent: Tatsuo Ishii <ishii@postgresql.org>
1 sibling, 1 reply; 5+ messages in thread
From: Robert Haas @ 2015-08-09 02:48 UTC (permalink / raw)
To: Tatsuo Ishii <ishii@postgresql.org>; +Cc: pgsql-committers
On Sat, Aug 8, 2015 at 10:09 PM, Tatsuo Ishii <ishii@postgresql.org> wrote:
> Fix broken multibyte regression tests.
>
> commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte
That commit ID isn't valid; should be
9043ef390f4f0b4586cfe59cbd22314b9c3e2957 - looks like ef got turned
into fe.
Sorry about the oversight.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Fix broken multibyte regression tests.
@ 2015-08-09 03:06 Tatsuo Ishii <ishii@postgresql.org>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 0 replies; 5+ messages in thread
From: Tatsuo Ishii @ 2015-08-09 03:06 UTC (permalink / raw)
To: robertmhaas@gmail.com; +Cc: pgsql-committers
> On Sat, Aug 8, 2015 at 10:09 PM, Tatsuo Ishii <ishii@postgresql.org> wrote:
>> Fix broken multibyte regression tests.
>>
>> commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte
>
> That commit ID isn't valid; should be
> 9043ef390f4f0b4586cfe59cbd22314b9c3e2957 - looks like ef got turned
> into fe.
Sorry for it. I seemd to touch wrong emacs keys.
> Sorry about the oversight.
No problem. The test is not in the regular regression suits, and it is
hard to find a brokenness.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Fix broken multibyte regression tests.
@ 2015-11-28 18:55 Tom Lane <tgl@sss.pgh.pa.us>
parent: Tatsuo Ishii <ishii@postgresql.org>
1 sibling, 0 replies; 5+ messages in thread
From: Tom Lane @ 2015-11-28 18:55 UTC (permalink / raw)
To: Tatsuo Ishii <ishii@postgresql.org>; +Cc: pgsql-committers
Tatsuo Ishii <ishii@postgresql.org> writes:
> Fix broken multibyte regression tests.
> commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte
> regression tests because the commit removes the warning message when
> temporary hash indexes is created, which has been added by commit
> 07af523870bcfe930134054febd3a6a114942e5b.
> Back patched to 9.5 stable tree.
AFAICT this patch was incorrect and should be reverted, because the
src/test/mb tests all fail for me, in both HEAD and 9.5, as a consequence
of getting hash-index WARNINGs that are not in the expected-files. The
commit you mention (which is 9043ef390f4f0b4586cfe59cbd22314b9c3e2957 not
what's cited in this commit message) disabled the WARNING for temporary
and unlogged hash indexes, but the indexes created by the test scripts
are neither.
Please recheck it.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2015-11-28 18:55 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2015-08-09 02:09 pgsql: Fix broken multibyte regression tests. Tatsuo Ishii <ishii@postgresql.org>
2015-08-09 02:48 ` Robert Haas <robertmhaas@gmail.com>
2015-08-09 03:06 ` Tatsuo Ishii <ishii@postgresql.org>
2015-11-28 18:55 ` Tom Lane <tgl@sss.pgh.pa.us>
2015-08-09 02:09 pgsql: Fix broken multibyte regression tests. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox