agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve
5+ messages / 3 participants
[nested] [flat]
* pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve
@ 2016-10-12 16:20 Tom Lane <tgl@sss.pgh.pa.us>
2016-10-12 18:17 ` Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2016-10-12 16:20 UTC (permalink / raw)
To: pgsql-committers
Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers.
The need for dumping from such ancient servers has decreased to about nil
in the field, so let's remove all the code that catered to it. Aside
from removing a lot of boilerplate variant queries, this allows us to not
have to cope with servers that don't have (a) schemas or (b) pg_depend.
That means we can get rid of assorted squishy code around that. There
may be some nonobvious additional simplifications possible, but this patch
already removes about 1500 lines of code.
I did not remove the ability for pg_restore to read custom-format archives
generated by these old versions (and light testing says that that does
still work). If you have an old server, you probably also have a pg_dump
that will work with it; but you have an old custom-format backup file,
that might be all you have.
It'd be possible at this point to remove fmtQualifiedId()'s version
argument, but I refrained since that would affect code outside pg_dump.
Discussion: <2661.1475849167@sss.pgh.pa.us>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/64f3524e2c8deebc02808aa5ebdfa17859473add
Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 7 +-
src/bin/pg_dump/dumputils.c | 50 +-
src/bin/pg_dump/pg_backup_archiver.c | 2 +-
src/bin/pg_dump/pg_dump.c | 1761 ++++------------------------------
src/bin/pg_dump/pg_dump.h | 1 -
src/bin/pg_dump/pg_dump_sort.c | 96 +-
src/bin/pg_dump/pg_dumpall.c | 110 +--
7 files changed, 250 insertions(+), 1777 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve
2016-10-12 16:20 pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve Tom Lane <tgl@sss.pgh.pa.us>
@ 2016-10-12 18:17 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2016-10-12 18:56 ` Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 5+ messages in thread
From: Peter Eisentraut @ 2016-10-12 18:17 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-committers
On 10/12/16 12:20 PM, Tom Lane wrote:
> Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers.
It looks like this or a related commit has caused these compiler warnings:
pg_dump.c: In function 'getTypes':
pg_dump.c:3692:8: error: variable 'i_typoutput' set but not used
[-Werror=unused-but-set-variable]
int i_typoutput;
^~~~~~~~~~~
pg_dump.c:3691:8: error: variable 'i_typinput' set but not used
[-Werror=unused-but-set-variable]
int i_typinput;
^~~~~~~~~~
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve
2016-10-12 16:20 pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve Tom Lane <tgl@sss.pgh.pa.us>
2016-10-12 18:17 ` Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
@ 2016-10-12 18:56 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2016-10-12 18:56 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; +Cc: pgsql-committers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 10/12/16 12:20 PM, Tom Lane wrote:
>> Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers.
> It looks like this or a related commit has caused these compiler warnings:
> pg_dump.c: In function 'getTypes':
> pg_dump.c:3692:8: error: variable 'i_typoutput' set but not used
> [-Werror=unused-but-set-variable]
> int i_typoutput;
> ^~~~~~~~~~~
> pg_dump.c:3691:8: error: variable 'i_typinput' set but not used
> [-Werror=unused-but-set-variable]
> int i_typinput;
> ^~~~~~~~~~
Ah, I'd not noticed because my compiler doesn't complain.
Will fix, thanks.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-9.2 serve
@ 2021-12-14 22:09 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2021-12-14 22:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove pg_dump/pg_dumpall support for dumping from pre-9.2 servers.
Per discussion, we'll limit support for old servers to those branches
that can still be built easily on modern platforms, which as of now
is 9.2 and up. Remove over a thousand lines of code dedicated to
dumping from older server versions. (As in previous changes of
this sort, we aren't removing pg_restore's ability to read older
archive files ... though it's fair to wonder how that might be
tested nowadays.) This cleans up some dead code left behind by
commit 989596152.
Discussion: https://postgr.es/m/2923349.1634942313@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/30e7c175b81d53c0f60f6ad12d1913a6d7d77008
Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 19 +-
src/bin/pg_dump/dumputils.c | 32 +-
src/bin/pg_dump/pg_backup_archiver.c | 9 +-
src/bin/pg_dump/pg_dump.c | 1846 +++++++---------------------------
src/bin/pg_dump/pg_dumpall.c | 272 +----
5 files changed, 417 insertions(+), 1761 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-v10 serve
@ 2026-07-02 18:06 Nathan Bossart <nathan@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Nathan Bossart @ 2026-07-02 18:06 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove pg_dump/pg_dumpall support for dumping from pre-v10 servers.
Per discussion, it seems like a good time to bump the minimum
supported version for various applications. Our current policy is
to support at least 10 previous major versions, so this bumps the
minimum to v10 for the v20 release. For reference, the minimum was
last bumped to v9.2 in 2021 for v15 (see commits 30e7c175b8,
e469f0aaf3, cf0cab868a, and 492046fa9e). As in previous changes of
this sort, we aren't removing pg_restore's ability to read older
archive files, though it's fair to wonder how that might be tested
nowadays.
For ease of review, and to be able to put the indentation changes
in .git-blame-ignore-revs, I did not fix the indentation in this
patch. I'll push a separate pgindent commit after these changes
are applied.
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/adZ4j88Dq9r8y9_9%40nathan
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3a0a30884fd08301f211f064c1433f8148e67c3a
Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 14 +-
doc/src/sgml/runtime.sgml | 2 +-
src/bin/pg_dump/connectdb.c | 4 +-
src/bin/pg_dump/pg_dump.c | 336 +++---------------------------------------
src/bin/pg_dump/pg_dumpall.c | 28 ----
5 files changed, 24 insertions(+), 360 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-07-02 18:06 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 16:20 pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve Tom Lane <tgl@sss.pgh.pa.us>
2016-10-12 18:17 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2016-10-12 18:56 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-12-14 22:09 pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-9.2 serve Tom Lane <tgl@sss.pgh.pa.us>
2026-07-02 18:06 pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-v10 serve Nathan Bossart <nathan@postgresql.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox