From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove some unnecessary fields from Plan trees.
Date: Sun, 07 Oct 2018 18:33:27 +0000
Message-ID: <E1g9Drr-0003pQ-Az@gemulon.postgresql.org> (raw)
Remove some unnecessary fields from Plan trees.
In the wake of commit f2343653f, we no longer need some fields that
were used before to control executor lock acquisitions:
* PlannedStmt.nonleafResultRelations can go away entirely.
* partitioned_rels can go away from Append, MergeAppend, and ModifyTable.
However, ModifyTable still needs to know the RT index of the partition
root table if any, which was formerly kept in the first entry of that
list. Add a new field "rootRelation" to remember that. rootRelation is
partly redundant with nominalRelation, in that if it's set it will have
the same value as nominalRelation. However, the latter field has a
different purpose so it seems best to keep them distinct.
Amit Langote, reviewed by David Rowley and Jesper Pedersen,
and whacked around a bit more by me
Discussion: https://postgr.es/m/468c85d9-540e-66a2-1dde-fec2b741e688@lab.ntt.co.jp
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/52ed730d511b7b1147f2851a7295ef1fb5273776
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 2 +-
src/backend/executor/execParallel.c | 1 -
src/backend/executor/execPartition.c | 2 +-
src/backend/nodes/copyfuncs.c | 5 +--
src/backend/nodes/outfuncs.c | 8 +---
src/backend/nodes/readfuncs.c | 5 +--
src/backend/optimizer/plan/createplan.c | 42 +++---------------
src/backend/optimizer/plan/planner.c | 78 +++++++++++----------------------
src/backend/optimizer/plan/setrefs.c | 31 +++----------
src/backend/optimizer/util/pathnode.c | 8 ++--
src/include/nodes/plannodes.h | 27 +++++-------
src/include/nodes/relation.h | 4 +-
src/include/optimizer/pathnode.h | 2 +-
13 files changed, 61 insertions(+), 154 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove some unnecessary fields from Plan trees.
In-Reply-To: <E1g9Drr-0003pQ-Az@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox